Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menufix - Holds the menu open #11

Closed
wants to merge 2 commits into from

Conversation

phillip-haydon
Copy link
Contributor

Because now that everything is responsive, theres no need to collapse the menu:

image

Repo screen

image

PR screen

@phillip-haydon
Copy link
Contributor Author

Oh, I did it using JS because changing the CSS messes things up, spent an hour trying to work out why and i can't figure out why, I think they use JS to determine what to do with the screen when the menu is open or not.

@thecodejunkie
Copy link
Owner

Tested it out a bit and the latency of the js-approach really bothered me. I decided to implement a css-version. The version only expands the menu for the 1400, 1600 and 1800 break points so it does not affect smaller resolutions. Hope I didn't break anything else ;)

The extension has been updated in the Chrome Store and will be available as soon as it's been published.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants