Join GitHub today
Azure storage driver #372
@@ Coverage Diff @@ ## master #372 +/- ## ========================================== - Coverage 30.83% 30.47% -0.36% ========================================== Files 29 29 Lines 1719 1739 +20 ========================================== Hits 530 530 - Misses 1131 1151 +20 Partials 58 58
This is a great PR -- thank you so very much the obvious time and effort you spent on this. I have some suggestions/questions to which I hope you're able to respond below.
One question I had regarding the entire PR is whether or not you used the GoMetalinter or at least go-fmt to ensure the files are consistent in their syntax/style?
Also, if possible can you try and limit the width of lines to 80 chars. I may be pedantic, but I find it makes things easier to read.
Thank you again!
Echo'ing what @akutz said, thanks for the very thorough and complete PR! Hurray for tests.
Most of my comments are minor. My main feedback is that I don't think the filtering in toTypeVolume is necessary, and i also think that handling of the attachmentState can be handled by the framework instead of the driver.
Just have the one remaining comment on device names. I'll start playing with this on Azure!
I'd like to see a first attempt made at adding the driver into the docs, at .docs/user-guide/storage-providers.md.
Should be interesting, as I haven't used Azure before.