Simplified Structure #991
Merged
Simplified Structure #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/simplified-structure
branch
from
6263f3c
to
6f414e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 34.15% 34.15% -0.01%
==========================================
Files 36 36
Lines 2893 2896 +3
==========================================
+ Hits 988 989 +1
- Misses 1803 1805 +2
Partials 102 102
Continue to review full report at Codecov.
|
This patch accomplishes the following: * Simplifies the source tree structure * Simplifies the build tags * Removes the ability to start service in the background. The service is always started in the foreground and relies on SystemD to start in the background.
akutz
force-pushed
the
feature/simplified-structure
branch
from
6f414e6
to
1fe8abe
Compare
codenrhoden
approved these changes
Aug 28, 2017
| @@ -1,14 +1,14 @@ | |||
| package context | |||
|
|
|||
| import ( | |||
| "context" | |||
There was a problem hiding this comment.
so is this possible because we are only on GO 1.[7-9] now? If so, do we need to update travis.yml to reflect that?
There was a problem hiding this comment.
Hi @codenrhoden,
The .travis.yml Go version is 1.8.3 as we discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch accomplishes the following:
-l,--logLevelhappens before everythingagentpackage at the root of RR; this is the service responsible for hosting long running moduleslibstoragefile or directory names expected or created at runtime. Everything happens under the brandrexrayutilpackage now defers to libStorage's path config. This means thatrexray startas a normal user will automatically create files in your$HOME/.rexraydirectory if you don't have root permissions.-c,--configspecifies a custom config and all other config files are ignored