-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taking High damage when using Hooks #9
Comments
Okay I think this maybe user error :-) Sorry to have bothered you. |
Hello again.
I still don't think I am doing it properly though, I'm thinking I need to anchor myself between two hooks. |
Just done a run through the Nether. Was going really well then a few of the 'bashing against a single hook deals damage' took place and I died quite a few times. When I hear the damage noise now I launch another hook anywhere to get out of the damage loop. I've had a couple of deaths as well due to the game thinking I am dropping a great height when I have been no more than 3 blocks off the ground. Thinking it might be related to some charms I have in my inventory, one of which gives Slow Fall when it detects you are falling, I removed them all from my inventory but the above problems continued. I'm going to launch a vanilla instance in Creative and see what happens when play with Hooks. As no one else seems to be seeing this I can only assume some other mode is interfering. |
Okay, loaded up a fresh 1.12.2 instance and just loaded the Hooked mod plus the required mods listed. Not good news I am afraid. Went down to the Nether and started hooking around. Note I was using a Diamond Hook Test 1 was standard 2 hook setup with me hovering in the mid point. This worked but a couple of times but I also took damage when I released (SHIFT-C) the second hook. Test 2 was multiple hooks with me at Hooks intersection point. 5 Hooks - died within 10 seconds. Test 3 was a simple hook from about 15 blocks high on to Netherack. Nothing in the way, clear ground. Only other thing I had active was Night Vision via a potion. Have a good weekend |
I noticed I started taking a bunch of damage while using hooks after updating my instance to Forge 2739. I also see messages like this in the log every time I use a hook:
|
Okay, so given those examples and that log it looks like a sync issue. I just looked really quick and I think I know part of the problem. I don't send an update packet when an invalid hook is fired, which means the client goes on its merry way, unaware that the server disagrees with it. Should be simple enough to send a sync packet when an invalid hook is fired. |
Can you tell me your modpack/modlist and configs, as well as a procedure to reproduce the issue. Details like if you’re on a server, if there’s tick lag, and if you’ve got client lag (especially < 20fps) would help as well. |
I can't seem to reproduce this issue. I tried on a server with 1000ms latency and like 2tps and it worked fine (as fine as anything could run under those conditions.) If it isn't latency or lag causing it I have no idea what it is. |
Did you try latest build of forge? I'm 95% sure that's what triggered the
problem for me. Sorry I haven't posted a full log, can try to do that
today.
…On Sat, Aug 4, 2018, 3:50 AM thecodewarrior ***@***.***> wrote:
I can't seem to reproduce this issue. I tried on a server with 1000ms
latency and like 2tps and it worked fine (as fine as anything could run
under those conditions.) If it isn't latency or lag causing it I have no
idea what it is.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD0beuxjJZv-eXDPtDkZTTI-32tTqWmks5uNVIzgaJpZM4VhbRS>
.
|
I still can't reproduce it reliably. I've taken damage a couple times in at least an hour of testing, but nothing reliable and nothing in a dev environment. |
Steps to reproduce:
Log: latest.log |
That worked! Now to figure out why it worked. :P |
So the culprit here is LibLib. Something changed from 4.9 to 4.11 that is breaking the fall damage nullification. |
Thanks, downgrading LibrarianLib to 4.9 is an effective workaround. |
Spoke a little too soon. FYI for others in the same boat: Downgrading LibrarianLib with my existing world caused a deserialization error when a player with the hooked capability stored in the player NBT data tried to log in. I was able to fix it by using NBT Explorer to delete the key |
This was a bug in LibrarianLib which will be resolved once 4.12 is released. Until then I'll keep this open so people in the same boat will be able to find it. |
@thecodewarrior LibrarianLib 4.12 doesn't appear to correct the problem; I can still trivially get falling damage with either the ender hook scenario above, or using a red hook and raising/lowering myself repeatedly. Edit: In case it's helpful, still getting this with every hook: |
Can confirm I'm also still having this issue after updating LLib to 4.12 ( Just using the iron hook works as well )
|
@esotericist can you reproduce it within 10 blocks of Serialization errors seem to cause the spawn position to be |
This is correct, as when slightly far enough out from 0, 0, 0 I get It does also appear to be fixing the issue of taking fall damage, although doing an extensive test within tight bounds is a bit difficult. |
I was able to reproduce this as well, and I'm not sure how but 1.0.1 (which just got approved) fixes it. It's confusing, because I didn't make any changes directly related to this. I'd like you to confirm whether it is fixed for you before I close however. |
Sadly, when I load 1.0.1 in an existing world, this happens. I already had latest (4.12) librarianlib in the previous load of the world. |
Just cleaning out the issues, is this still an issue with 1.0.3? If not I'll close this. |
Seems to be working okay for me. |
Can I ask how the damage system works with respect to Hooked?
For example I hook to a ledge, hook is 2 blocks higher than the ledge. I jump to release and take a heart of damage
Occasionally I fall 4 blocks and take 4 hearts of damage. Jumping off a 4 high block of dirt on to grass gives me a half heart of damage.
Very occasionally I start taking constant damage when I hook to a block. It looks like I am banging up against the hook itself.
Added: I'll try and get you some Use Cases where it goes a bit wobbly.
Thank you.
The text was updated successfully, but these errors were encountered: