Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why are the particles sampling velocities given to be in m/s #96

Closed
geoeo opened this issue Oct 28, 2022 · 2 comments
Closed

Comments

@geoeo
Copy link

geoeo commented Oct 28, 2022

As far as I understand the particles in the grid live in the grid space (cells).
But according to the Params structure (comments) the sampling velocities are in m/s?

@TheCodez
Copy link
Owner

Yes, currently particles are in the grid space though it would be better if they were in world space. This PR fixes that, but I haven't got around to integrating it yet.
So you're right, the documentation for the param says m/s when in reality it's currently m/s / resolution (same applies to the process noise). I'll try to fix that once I find some time.

@geoeo
Copy link
Author

geoeo commented Oct 31, 2022

Thanks for clearing it up. I was wondering why I had to put higher noise values than would be expected with m/s

@geoeo geoeo closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants