Delete references to pending issues before releasing 1.0 from readme #173
Conversation
Yes, technicall 0 is a number, but we don't need to mention it.
|
I'm not sure why the checks have failed on this change. |
|
The ci always tries to regenerate the files and then compare to what is commited. The php doc has been updated recently which cause a change in the doc block of a generated function. You need to update the doc of you local project before regenerating the files (check CONTRIBUTING.md to see how to do all of this). |
|
Ok, I've run the generator and commited the change. I wonder if there's interest in making this proccess more automated - I might be able to work on that. Potentially you could have a bot to submit PRs when the upstream docs change, or remove the generated stuff from source control entirely and make it just part of a build. Maybe have two github repos, one manually edited without the generated stuff, and one auto generated based on a build from the first one and including the generated code for people to download and use. |
|
I don't know. I like that it is still commited and has to be manually regenerated by a person, this makes it easier to track who modified what. You also need to have a local copy of the generated files to run your tests locally. |
|
Also, people than require the library via composer don't download the generator code since it is labeled as export-ignore in .gitattributes |
Yes, technically 0 is a number, but we don't need to mention it.