Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #42, #46 and #47 #45

Merged
merged 5 commits into from
Dec 19, 2020
Merged

Fix #42, #46 and #47 #45

merged 5 commits into from
Dec 19, 2020

Conversation

papb
Copy link
Contributor

@papb papb commented Dec 8, 2020

Hello, this PR fixes a few issues!

@papb
Copy link
Contributor Author

papb commented Dec 8, 2020

And thanks for this great package. I am sorry for not adding any tests, I really don't have time for that right now. I will be using my fork in the mean time. But at least I can ensure you that by using my fork the async issue I mentioned disappeared.

If anyone else also wants to, you can just do:

# npm
npm install --save https://github.com/papb/fdir/tarball/5c2f71373b6a1e08637b4dcfcb8ae1d9ae298ad3

# yarn
yarn add https://github.com/papb/fdir/tarball/5c2f71373b6a1e08637b4dcfcb8ae1d9ae298ad3

@papb papb changed the title Fix #42 and fix concurrent async execution Fix #42, #46 and #47 Dec 15, 2020
@papb
Copy link
Contributor Author

papb commented Dec 15, 2020

Update: added more commits to fix #46 as well.

@thecodrr
Copy link
Owner

thecodrr commented Dec 19, 2020

Hey @papb

Thank you so much for taking the time : )

So sorry for the late response, I'll be taking a look into the PR shortly. I need to run benchmarks and see how the concurrency issue is affecting the performance.

Will be leaving a review in a bit.

@thecodrr thecodrr merged commit aa39f15 into thecodrr:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants