Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V4] After updating to the newest version tabs do not work properly if "fade" class is used. #168

Closed
Veesparion opened this issue Nov 1, 2017 · 5 comments
Assignees
Labels
bug critical issue

Comments

@Veesparion
Copy link

After updating to the newest version tabs do not work properly if "fade" class is used.

First switch to lets say second tab works okay but then i cant switch back to the 1st tab unless i wait around 20-30 seconds then it works so basically switching between tabs works once per 20-30 seconds.

If fade class is not used it works fine.

@Veesparion Veesparion changed the title After updating to the newest version tabs do not work properly if "fade" class is used. [V4] After updating to the newest version tabs do not work properly if "fade" class is used. Nov 1, 2017
@thednp
Copy link
Owner

thednp commented Nov 1, 2017

The demo is using the latest code and the fade class. But will check further.

@Veesparion
Copy link
Author

Its the height animation while its happening it blocks the tab switch, if you try to switch tabs fast even in the demo you sometimes cant switch the tab.

@thednp
Copy link
Owner

thednp commented Nov 1, 2017

That is the point, wait for height animation to finish first. BUT you're right on the first issue.

thednp added a commit that referenced this issue Nov 2, 2017
* Fixing V3/V4 in regards to #168
* `styleTip` utility is more consistent with Tooltip and Popover
thednp added a commit that referenced this issue Nov 2, 2017
* Fixing V3/V4 in regards to #168
* `styleTip` utility is more consistent with Tooltip and Popover
@thednp
Copy link
Owner

thednp commented Nov 2, 2017

@Veesparion please test latest master. It now works perfect with/without fade class and with/without the height animation in all browsers.

@thednp thednp added the bug critical issue label Nov 2, 2017
@thednp thednp closed this as completed Nov 2, 2017
@thednp
Copy link
Owner

thednp commented Nov 3, 2017

Just to give you some insights: the issue was present some versions back but forgot to take care of them, so I'm sorry. Also was present with both V3 and V4 versions.

The current master has this issue fixed finally and we an go forward now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue
Projects
None yet
Development

No branches or pull requests

2 participants