Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel (v4) interval bug #169

Closed
Vuurvlieg opened this issue Nov 9, 2017 · 5 comments
Closed

Carousel (v4) interval bug #169

Vuurvlieg opened this issue Nov 9, 2017 · 5 comments
Assignees
Labels
bug critical issue

Comments

@Vuurvlieg
Copy link

Hi there!

I want to stop automatic sliding for the Carousel component, so I set the interval to false. However, the library ignores this and grabs the default 5000.

I created a quick fix by changing

if ( !( options[interval] || intervalData ) ) { // determine slide interval

to

if ( !options[interval] || !intervalData ) { // determine slide interval

@thednp
Copy link
Owner

thednp commented Nov 9, 2017

That is correct, however, if you set data-interval="false" it's not going to automatically cycle.

@Vuurvlieg
Copy link
Author

Well, the library ignores (and thus cycle automcatically) when using Javascript directly, like

var myCarouselInit = new Carousel(myCarousel, { interval: false, pause: false, keyboard: false });

@thednp
Copy link
Owner

thednp commented Nov 15, 2017

@Vuurvlieg I'm working on something but I won't forget this. Closing this out.

@thednp thednp closed this as completed Nov 15, 2017
@thednp thednp added the bug critical issue label Nov 15, 2017
thednp added a commit that referenced this issue Nov 20, 2017
* up/down arrow keys menu selection
* Esc key now closes last open nested dropdown menu
* While the dropdown is open, pressing up/down arrows the component will prevent the default scroll behavior

Also fixing #169
thednp added a commit that referenced this issue Nov 20, 2017
* up/down arrow keys menu selection
* Esc key now closes last open nested dropdown menu
* While the dropdown is open, pressing up/down arrows the component will prevent the default scroll behavior

Also fixing #169
@thednp
Copy link
Owner

thednp commented Nov 21, 2017

@Vuurvlieg I commited new code last night, I also added a new feature.

Please download the master and do some checks, thanks.

@Vuurvlieg
Copy link
Author

@thednp I checked it roughly and it seems to work now. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue
Projects
None yet
Development

No branches or pull requests

2 participants