Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown aria-expanded #245

Closed
marius-doros opened this issue Oct 5, 2018 · 8 comments
Closed

Dropdown aria-expanded #245

marius-doros opened this issue Oct 5, 2018 · 8 comments
Assignees
Labels
bug critical issue

Comments

@marius-doros
Copy link

marius-doros commented Oct 5, 2018

The attribute aria-expanded is initially set as false on the dropdown trigger;
When dropdown is opened instead of set this attribute as true, an aria-expanded attribute, set as true, is added on the UL element

@thednp
Copy link
Owner

thednp commented Oct 6, 2018

You have a demo please?

@marius-doros
Copy link
Author

You could check on http://thednp.github.io/bootstrap.native/ dropdown demo. Also on http://thednp.github.io/bootstrap.native/v4.html dropdown. I used Google Chrome Version 69.0.3497.100 (Official Build) (64-bit). Also in Edge Microsoft Edge 42.17134.1.0 and Firefox Quantum 62.0.3 (64-bit)

@thednp thednp added the bug critical issue label Oct 8, 2018
@thednp
Copy link
Owner

thednp commented Oct 8, 2018

Yea, I'll take care of that right away.

@marius-doros
Copy link
Author

Thank you

thednp added a commit that referenced this issue Oct 8, 2018
thednp added a commit that referenced this issue Oct 8, 2018
@thednp
Copy link
Owner

thednp commented Oct 8, 2018

OK now, please do some tests with the latest master.

@thednp thednp closed this as completed Oct 8, 2018
@marius-doros
Copy link
Author

Tested v3 and v4. The issue is fixed.

@marius-doros
Copy link
Author

Please, could you release 2.0.24? I need this fix in order to release my component. Thank you.

@thednp
Copy link
Owner

thednp commented Oct 26, 2018

https://github.com/thednp/bootstrap.native/releases/tag/2.0.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue
Projects
None yet
Development

No branches or pull requests

2 participants