Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set touch event listeners to passive #280

Closed
midzer opened this issue Apr 19, 2019 · 1 comment
Closed

Set touch event listeners to passive #280

midzer opened this issue Apr 19, 2019 · 1 comment
Labels
enhancement potential improvement

Comments

@midzer
Copy link
Contributor

midzer commented Apr 19, 2019

Hi!

Since 2.0.26 lighthouse reports new touch event listeners not being set to passive on my site.
We can improve this by setting { passive: true } on their handler, see https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners

Have a nice easter weekend
midzer
thednp added a commit that referenced this issue Jun 3, 2019
@thednp
Changes:
b0b574f 
* attempting to fix #233
* added passive event options to resize, touch, scroll events #283 & #280
* code cleanup
thednp added a commit that referenced this issue Jun 3, 2019
@thednp
Changes:
3b33005 
* attempting to fix #233
* added passive event options to resize, touch, scroll events #283 & #280
* code cleanup
@thednp thednp added the enhancement potential improvement label Jun 30, 2019
@thednp
Copy link
Owner

thednp commented Jun 30, 2019

Implemented, closed.

@thednp thednp closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement potential improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@midzer @thednp