Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] svgTransform: skews and translate don't work right together #33

Closed
thednp opened this issue Aug 25, 2016 · 0 comments
Closed

[Bug] svgTransform: skews and translate don't work right together #33

thednp opened this issue Aug 25, 2016 · 0 comments

Comments

@thednp
Copy link
Owner

thednp commented Aug 25, 2016

As of now, the plugin only adjusts the translation when scale is used, but rotation transform-origin also need to be adjusted according to the translation. Fixed.

The plugin also does not tween the transform-origin coordinates of rotation. WON'T FIX: the plugin will require proper order of transform functions, so no need to tween the transform origin coordinates, all just as described in the recommended draft. Forcing a certain order via the update function produces a significant performance drop.

Also the demo has no mixed SVG transforms. Fixed: also make some cool chained transform.

When using skews because the SVG coordinates system, the shapes get stretched and pushed along respective axis. We need to find a way to compensate with translate, similar to when scale is used. WON'T FIX - changing the translation based on skews complicates things alot and it's not reliable with yoyo, chains, etc.

Attempting a new version of SVG transforms. The new attempt is to get translation from computed matrix applying transform functions step by step, sounds like an interesting idea but I will try it nevertheless.

Update - I think I managed to get this thing to work properly, except stacking SVG transform chains.

This issue is now fixed.

@thednp thednp added the bug label Aug 25, 2016
@thednp thednp added this to the 1.5.3 milestone Aug 25, 2016
@thednp thednp self-assigned this Aug 25, 2016
@thednp thednp added the wontfix label Aug 28, 2016
@thednp thednp closed this as completed Aug 28, 2016
@thednp thednp changed the title [Bug] svgTransform: rotations and translate don't work right together [Bug] svgTransform: skews and translate don't work right together Aug 28, 2016
@thednp thednp removed the wontfix label Aug 28, 2016
@thednp thednp reopened this Aug 28, 2016
thednp added a commit that referenced this issue Sep 3, 2016
Improved overall performance #34
Fixed some issues with SVG Plugin #33
Documentation updates
thednp added a commit that referenced this issue Sep 3, 2016
Improved overall performance #34
Fixed some issues with SVG Plugin #33
Documentation updates
@thednp thednp closed this as completed Sep 3, 2016
@thednp thednp reopened this Dec 4, 2016
@thednp thednp modified the milestones: 1.6.0, 1.5.3 Dec 4, 2016
@thednp thednp closed this as completed Dec 6, 2016
thednp added a commit that referenced this issue Dec 11, 2016
* fixing SVG transforms for good #33
* major changes to the tween objects #39
* back to Infinity repeat #43
* all round performance improvements
thednp added a commit that referenced this issue Dec 11, 2016
* fixing SVG transforms for good #33
* major changes to the tween objects #39
* back to Infinity repeat #43
* all round performance improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant