Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Tween object #39

Closed
thednp opened this issue Sep 24, 2016 · 0 comments
Closed

Simplify the Tween object #39

thednp opened this issue Sep 24, 2016 · 0 comments
Assignees
Milestone

Comments

@thednp
Copy link
Owner

thednp commented Sep 24, 2016

There's alot of stuff stored in the Tween function's this that are actually not needed in the scope of execution, and they take a huge chunk of memory. However, we do want to pass it to all string parsing functions.

UPDATE:

  • now the Tween constructor is getting lighter, the tween objects created give alot more freedom to garbage collector DONE
  • alot of public methods are no longer public, to simplify the Tween constructor and improve performance DONE
  • the tween object will store the prefixed properties if that's the case, to improve performance DONE
  • add perspective as a transform object property as already formatted string DONE
  • box model props are transformed from % unit to px via element.offsetWidth DONE
  • translations are transformed from % unit to px via element.offsetWidth / element.offsetHeight DONE
  • rotations and skews are transformed from rad to deg via value * 180/Math.PI DONE
  • add all SVG/non-SVG stack transforms and svg path processing into a new crossCheck object DONE
  • apply this in all crossCheck functions DONE
  • apply this in all parseProperty and prepareStart functions DONE

More updates to come.

@thednp thednp added this to the 1.5.9 milestone Sep 24, 2016
@thednp thednp self-assigned this Sep 24, 2016
thednp added a commit that referenced this issue Oct 3, 2016
#39

Also fixing #40

Minor documentation changes
thednp added a commit that referenced this issue Oct 3, 2016
#39

Also fixing #40

Minor documentation changes
@thednp thednp modified the milestones: 1.6.0, 1.5.9 Oct 7, 2016
thednp added a commit that referenced this issue Dec 11, 2016
* fixing SVG transforms for good #33
* major changes to the tween objects #39
* back to Infinity repeat #43
* all round performance improvements
thednp added a commit that referenced this issue Dec 11, 2016
* fixing SVG transforms for good #33
* major changes to the tween objects #39
* back to Infinity repeat #43
* all round performance improvements
@thednp thednp closed this as completed Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant