fix(lib): conditionally include default slot

Components that have conditional logic based on the presence of `<slot />` would be challenged by Cartesian adding a `<slot />` element of its own. With this fix, Cartesian will only explicitly pass default `<slot />` contents to the provided component when there are explicitly-included default slot contents.
theetrain · Aug 29, 2024 · 063ff16 · 063ff16
1 parent 2a965f3
commit 063ff16
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/e2e/svelte-4/package-lock.json b/e2e/svelte-4/package-lock.json
diff --git a/e2e/svelte-5/package-lock.json b/e2e/svelte-5/package-lock.json
diff --git a/lib/Cartesian.svelte b/lib/Cartesian.svelte
@@ -71,9 +71,13 @@
         {/if}
       {:else}
         <div>
-          <svelte:component this={Component} {...innerProps}>
-            <slot />
-          </svelte:component>
+          {#if $$slots.default}
+            <svelte:component this={Component} {...innerProps}>
+              <slot />
+            </svelte:component>
+          {:else}
+            <svelte:component this={Component} {...innerProps} />
+          {/if}
         </div>
         {#if showLabels}
           <div>

diff --git a/package-lock.json b/package-lock.json