Automatically select db on new connection creation in pool #34
Conversation
|
great ! just a little change proposal |
|
Ok. What should I do? |
| @@ -88,6 +91,10 @@ def get_connected_client(self): | |||
| LOG.warning("can't connect to %s", client.title) | |||
| raise tornado.gen.Return(ClientError("can't connect to %s" % | |||
| client.title)) | |||
|
|
|||
| if self.db != 0: | |||
| yield client.call('SELECT', self.db) | |||
There was a problem hiding this comment.
can you add a test about the result of the SELECT command and raise a tornado.gen.Return(ClientError("something")) if there is a problem here ?
There was a problem hiding this comment.
raise a tornado.gen.Return(ClientError("something"))
Done.can you add a test about the result
I have no idea how to figure out what db is selected right now (
There was a problem hiding this comment.
One more thing.
Please make release after this feature will be merged.
|
It seems good for me, I merge it |
|
Thank you. |
|
I just moved your db selection code from pool to client object. Same behaviour but you don't have db property anymore on the pool object (but on the client object) Can you test it ? |
|
Thanks. It works for me. |
No description provided.