Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA marathon 0.14.0 support #77

Closed
wants to merge 4 commits into from
Closed

NOJIRA marathon 0.14.0 support #77

wants to merge 4 commits into from

Conversation

dilyn
Copy link
Contributor

@dilyn dilyn commented Jan 29, 2016

No description provided.

@vito-c
Copy link

vito-c commented Jan 29, 2016

+1

@chrishaessig
Copy link

LGTM

@solarkennedy
Copy link
Contributor

Can you also expand the .travis.yaml to include marathon .14 support?

It looks like all the tests are passing... my best guess here is that we are pulling off of the mesossphere repos and the new version of mesos isn't compatible with the versions of marathon we are testing against. I'll come up with a fix for that and have you merge/rebase master.

@solarkennedy
Copy link
Contributor

Ok itests are fixed in master, please merge/rebase and let's see the results.

Also please add the new entry for marathon .14. At the same time please remove the next oldest version (0.8.1?) so we don't grow the matrix.

@lcjlcj
Copy link

lcjlcj commented Feb 3, 2016

I ran into this because marathon 0.14.0 added ipAddress in MarathonApp response. Mesos 0.26.0, marathon 0.14.0. Marathon-python 0.7.5.

File "/usr/local/lib/python2.7/dist-packages/marathon/client.py", line 104, in create_app
return self._parse_response(response, MarathonApp)
File "/usr/local/lib/python2.7/dist-packages/marathon/client.py", line 47, in _parse_response
return clazz.from_json(target)
File "/usr/local/lib/python2.7/dist-packages/marathon/models/base.py", line 34, in from_json
return cls(**{to_snake_case(k): v for k,v in attributes.items()})
TypeError: init() got an unexpected keyword argument 'ip_address'

This was referenced Feb 11, 2016
@solarkennedy
Copy link
Contributor

Obsoleted by #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants