Don't drop 0s when transforming to JSON #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool cool. Hang tight I've got a fix for the tests coming and I'll ask you to merge/rebase. |
|
Ok itests are fixed in master, please merge/rebase and let's see the results. |
This fixes issue thefactory#75
|
I rebased but it still seems to fail. I didn't find the link to see which test fails exactly. Do you have it? |
|
You can click on the red X in the pull request to see the output of the tests. Only one part of the matrix failed, I re-ran it but I'm sure it is fine. This fix is also in #77 but I'll go ahead and merge this in. Thanks! |
solarkennedy
added a commit
that referenced
this pull request
Jan 29, 2016
Don't drop 0s when transforming to JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #75