This repository has been archived by the owner on Jul 9, 2020. It is now read-only.
Fixes simplified grub2 MAC loading #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplified MAC loading works great:
#606
However, it does not when using grub2 in HTTP UEFI Boot. In that context, grub2 messes URL in memory and then fails to load any file. I have found out that when absolute paths are first, it works fine and only relative paths causes the bug to appear.
Also, instead of "source" we can now use "configfile" statement which prevents from "chainload" items below which can interfere with the included item.