Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run complete sync to Smart Proxy Server via CLI #2664

Merged

Conversation

maximiliankolb
Copy link
Contributor

See https://community.theforeman.org/t/how-to-do-same-things-as-complete-sync-of-smartproxy-with-hammer/34777/2?u=maximilian

Please cherry-pick my commits into:

  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)

@maximiliankolb
Copy link
Contributor Author

Can you please review my PR? @sjha4

Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stylewise

Copy link
Contributor

@bangelic bangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb merged commit 4819652 into theforeman:master Jan 12, 2024
8 checks passed
@maximiliankolb maximiliankolb deleted the cli_optimized_sync_smart_proxy branch January 12, 2024 13:44
@maximiliankolb
Copy link
Contributor Author

Merged to master and cherry-picked to 3.9: ✔️
7744370..f1ee34c 3.9 -> 3.9

@quba42
Copy link

quba42 commented Jan 12, 2024

@maximiliankolb I still think it should be with instead of without...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants