Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording on sync to Smart Proxy Server #2674

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

maximiliankolb
Copy link
Contributor

In Foreman+Katello, a "complete sync" does not rely on already existing metadata. Instead, the content is synchronized as if there was no metadata existing.
In the Web UI, it's called "Complete Sync"; for Hammer CLI, you use "--skip-metadata-check".
"skipping checks on metadata" or "without checking metadata" is technically correct.

Fixes #2664 (comment)

Please cherry-pick my commits into:

  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)

image

In Foreman+Katello, a "complete sync" does not rely on already existing
metadata. Instead, the content is synchronized as if there was no
metadata existing.
In the Web UI, it's called "Complete Sync"; for Hammer CLI, you use
"--skip-metadata-check".
"skipping checks on metadata" or "without checking metadata" is
technically correct.
@maximiliankolb
Copy link
Contributor Author

Thanks for catching this @quba42

Copy link
Contributor

@bangelic bangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb merged commit 9a58aa9 into theforeman:master Jan 15, 2024
8 checks passed
@maximiliankolb maximiliankolb deleted the fix_wording_cli_sync branch January 15, 2024 07:34
maximiliankolb added a commit that referenced this pull request Jan 15, 2024
In Foreman+Katello, a "complete sync" does not rely on already existing
metadata. Instead, the content is synchronized as if there was no
metadata existing.
In the Web UI, it's called "Complete Sync"; for Hammer CLI, you use
"--skip-metadata-check".
"skipping checks on metadata" or "without checking metadata" is
technically correct.

(cherry picked from commit 9a58aa9)
@maximiliankolb
Copy link
Contributor Author

Merged to master and cherry-picked to 3.9: ✔️
58edca5..294da7f 3.9 -> 3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants