Refs #33337 - Reflect Puppet isn't enabled by default #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Foreman 3.1 Puppet hasn't been enabled in the Katello scenario, but it is in vanilla Foreman.
|
The PR preview for d96a760 is available at theforeman-foreman-documentation-preview-pr-2690.surge.sh The following output files are affected by this PR: |
ekohl
force-pushed
the
no-default-puppet
branch
from
20c9b16
to
9d6e993
Compare
10 tasks
Lennonka
requested changes
Jan 23, 2024
pr-processor
bot
added
Waiting on contributor
ekohl
commented
Jan 23, 2024
Puppet is an implementation detail. Having it in gives the impression that Puppet runs as a daemon, but it doesn't.
ekohl
force-pushed
the
no-default-puppet
branch
from
9d6e993
to
d96a760
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
10 tasks
Lennonka
approved these changes
Jan 30, 2024
|
@Lennonka please merge this if you think it's good to go. |
|
Cherry-picked both commits to: Cherry-picked only the first commit to:
The second commit causes conflicts on 3.7 and older. FYI @ekohl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Foreman 3.1 Puppet hasn't been enabled in the Katello scenario, but it is in vanilla Foreman. It also rephrases the installer managed parts to avoid the implication that Puppet runs as a deamon.
Please cherry-pick my commits into: