-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite paragraph on installer managed files #2694
Rewrite paragraph on installer managed files #2694
Conversation
The PR preview for 50f2099 is available at theforeman-foreman-documentation-preview-pr-2694.surge.sh The following output files are affected by this PR: |
This makes it clear why the installer manages the files. Rather than presenting it as a downside, it explains why it's a feature. The part about DHCP and DNS is dropped since there are no instructions to set up DHCP and DNS here. If anything, they should be presented in the correct chapters.
f6b8b96
to
50f2099
Compare
Rebased now that #2690 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ekohl Can this be cherry-picked all the way back? |
Yes, since Foreman 3.1 I'd say this is correct. |
This makes it clear why the installer manages the files. Rather than presenting it as a downside, it explains why it's a feature.
The part about DHCP and DNS is dropped since there are no instructions to set up DHCP and DNS here. If anything, they should be presented in the correct chapters.
Builds on #2690 and currently a draft because of that.
Please cherry-pick my commits into: