Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite paragraph on installer managed files #2694

Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 23, 2024

This makes it clear why the installer manages the files. Rather than presenting it as a downside, it explains why it's a feature.

The part about DHCP and DNS is dropped since there are no instructions to set up DHCP and DNS here. If anything, they should be presented in the correct chapters.

Builds on #2690 and currently a draft because of that.

Please cherry-pick my commits into:

  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.

@ekohl ekohl mentioned this pull request Jan 24, 2024
10 tasks
@ekohl ekohl marked this pull request as draft January 24, 2024 18:53
This makes it clear why the installer manages the files. Rather than
presenting it as a downside, it explains why it's a feature.

The part about DHCP and DNS is dropped since there are no instructions
to set up DHCP and DNS here. If anything, they should be presented in
the correct chapters.
@ekohl ekohl force-pushed the rewrite-installer-managed-files-section branch from f6b8b96 to 50f2099 Compare January 31, 2024 14:55
@ekohl ekohl marked this pull request as ready for review January 31, 2024 14:55
@ekohl
Copy link
Member Author

ekohl commented Jan 31, 2024

Rebased now that #2690 is merged.

Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lennonka
Copy link
Contributor

@ekohl Can this be cherry-picked all the way back?

@ekohl
Copy link
Member Author

ekohl commented Jan 31, 2024

@ekohl Can this be cherry-picked all the way back?

Yes, since Foreman 3.1 I'd say this is correct.

@Lennonka Lennonka merged commit 62e090c into theforeman:master Feb 1, 2024
8 checks passed
@ekohl ekohl deleted the rewrite-installer-managed-files-section branch February 1, 2024 17:17
@Lennonka
Copy link
Contributor

Lennonka commented Feb 1, 2024

Cherry-picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants