-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change capitalization of guide titles #2874
Change capitalization of guide titles #2874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM. Any other comments? Else I'll merge as is.
b69762e
to
045934a
Compare
- Change guide title capitalization from title case to sentence case - Shortened a few names where the product name did not seem necessary - Updated d/s URLs Signed-off-by: Avital Pinnick <apinnick@redhat.com>
045934a
to
42d8052
Compare
@maximiliankolb I just noticed that the docinfo.xml files are not using the attributes. So I need to fix those as well. |
@maximiliankolb I was mistaken. All the docinfo.xml files have the doc title attributes, so they are fine. Only change I made was a level offset fix to an 'include'. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I assume you have tested the URLs for Satellite docs? Ping me and I will merge + cherry-pick both commits.
@maximiliankolb I can't test the URLs before this PR is merged because they have to be configured in Pantheon. When this PR is merged and synced with downstream, then I will update the titles in Pantheon so that the new URLs work. |
Please cherry-pick my commits into: