Move Katello npm install to parallel step #1495
Conversation
| withRVM(["bundle exec npm install"], ruby) | ||
| } | ||
| dir('katello') { | ||
| sh 'npm test' |
There was a problem hiding this comment.
There was an 'npm install' step here, but I removed it as foreman's npm install will install for plugins. I didn't see any additional installation happening for this step in our current runs.
There was a problem hiding this comment.
Also, there was this condition:
when {
expression { fileExists('package.json') }
}
Is this still needed? It seems implied now. If it is still needed, I could use some help on how to add it for just a single action in a step.
johnpmitsch
force-pushed
the
move_npm_to_parallel
branch
from
d6673c0
to
f9822ae
Compare
| dir('foreman') { | ||
| withRVM(["bundle exec npm install"], ruby) | ||
| } | ||
| dir('katello') { |
There was a problem hiding this comment.
I think you simply omit dir() when you want katello.
and combine react-ui and assets precompile. Both react tests and assets precompile need the installed npm packages, so we can combine them and install packages before running those tests. This will allow the long-running rails suite to not be blocked by an npm install.
johnpmitsch
force-pushed
the
move_npm_to_parallel
branch
from
f9822ae
to
c5dc609
Compare
|
@ekohl thanks, updated to not use
I'm not sure I'm understanding the question exactly, but |
|
We have moved the Jenkins job definitions over to https://github.com/theforeman/jenkins-jobs -- please re-open your PR against this new repository. |
and combine react-ui and assets precompile.
Both react tests and assets precompile need the installed npm packages, so we can combine them and install packages before running those tests. This will allow the long-running rails suite to not be blocked by an npm install.