Handle unknown releasers in packaging_build_rpm.sh #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 3 solutions I could think of:
Preventing the run in the first place by changing packaging_test_pull_request would be nice, but that job is not managed by JJB so was IMHO somewhat risky. It'd save more resources but this job fails very fast so should be light enough.
This made the most sense since it produces an understandable and short error message if it's somehow misconfigured. We can later always exit 1 when all known releasers are in all supported branches.
We could also add the releasers to the 1.15 and 1.16 branches.
In the end we might up using all 3.