refs #3272 - print new user/password after installation #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Foreman UI? | ||
| if module_enabled? 'foreman' | ||
| say " * <%= color('Foreman', :info) %> is running at <%= color('#{get_param('foreman','foreman_url')}', :info) %>" | ||
| say " Credentials are '<%= color('#{get_param('foreman', 'admin_user')} / #{get_param('foreman', 'admin_password')}', :info) %>'" if get_param('foreman','authentication') == true |
There was a problem hiding this comment.
One problem I do see is rerunning the installer to upgrade for example, but these will still only be the default parameters and the user could have changed the password.
There was a problem hiding this comment.
That's possible - the rake task is designed not to overwrite or change the admin user if one already exists, so it's actually an initial password. I've added the word "initial", which should clarify.
domcleal
changed the title
|
👍 pending other patch. |
|
|
|
Nice, our installer is pure awesomness. |
|
Depends on theforeman/puppet-foreman#192 at the moment. |
This was referenced May 20, 2014
|
Tested, works great, 👍 will merge when the core PR goes in. |
|
PR is merged, merge at will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on theforeman/puppet-foreman#190.
The change to print the details all the time might be needed if we had a partial failure, but enough that the web UI works - so as not to leave the user with no idea what their credentials are.