refs #3272 - pass admin user details into db:seed rake task #190
Conversation
| $admin_password = $foreman::params::admin_password, | ||
| $admin_first_name = $foreman::params::admin_first_name, | ||
| $admin_last_name = $foreman::params::admin_last_name, | ||
| $admin_email = $foreman::params::admin_email |
There was a problem hiding this comment.
We can use trailing commas now :)
|
Looks good to me. |
|
Rebased onto #192 so it will now configure the CLI with the username and password that were passed or randomised in 'foreman'. |
| $request_timeout = $::foreman::cli::params::request_timeout, | ||
| ) inherits foreman::cli::params { | ||
| # Inherit URL & auth parameters from foreman class if possible | ||
| $foreman_url_real = $foreman_url ? { |
There was a problem hiding this comment.
There's https://github.com/puppetlabs/puppetlabs-stdlib#pick: $foreman_url_real = pick($foreman_url, $::foreman::foreman_url) is more readable IMHO.
There was a problem hiding this comment.
Much better, thanks!
| @@ -127,7 +127,14 @@ | |||
|
|
|||
| # We need the REST API interface with OAuth for some REST Puppet providers | |||
| $oauth_active = true | |||
| $oauth_map_users = true | |||
| $oauth_map_users = false | |||
There was a problem hiding this comment.
I've changed this default as the foreman_proxy::register class needs to know the username otherwise of the account to register through. OAuth API access either works as the admin user (or anonymous API admin since #3272) or is mapped to a specific user account, I don't think we need the complication of the latter, certainly not by default.
domcleal
changed the title
|
Tested, works great, 👍 will merge when the core PR goes in. |
|
PR is merged, merge at will |
Review only, I've not made submitted the change to core yet - though it's otherwise harmless so we can merge once that's on track.
Depends on theforeman/foreman#1445.
Merge theforeman/foreman-installer#116 after this one.