Fixes #23727 - Rely on puppet-pulp to migrate the database #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
23727-pulp-migration
branch
from
958a926
to
b3715c2
Compare
ehelms
reviewed
Dec 2, 2019
| if katello || foreman_proxy_content | ||
| upgrade_step :migrate_pulp, :run_always => true | ||
| if File.exist?(PULP2_MIGRATION_MARKER_FILE) | ||
| File.unlink(PULP2_MIGRATION_MARKER_FILE) |
There was a problem hiding this comment.
https://puppet.com/docs/puppet/latest/type.html#exec-attribute-creates (currently direct links are broken) states:
creates => # A file to look for before running the command...
The exec runs pulp-manage-db && touch /var/lib/pulp/init.flag. That makes it idempotent. By removing the file, we trigger the exec and thus a database migration.
ehelms
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/theforeman/puppet-pulp/blob/9ee5f9e9539754a2a270695a70911dd6417a4de8/manifests/database.pp#L11-L18 should already take care of this. By removing the marker file we guarantee it runs. It also ensures the correct services are running prior to migration.