Rely on puppet-candlepin for cpdb execution #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehelms with the Foreman DB migration work added we can remove the |
ekohl
force-pushed
the
candlepin-migration
branch
from
f7657fa
to
6ee526d
Compare
|
You can take this out of draft and I think it's good to go. I would not drop the upgrade hook here due to postgres upgrades. |
ekohl
force-pushed
the
candlepin-migration
branch
from
6ee526d
to
7df6377
Compare
|
Rebased. Still depends on theforeman/puppet-candlepin#139 to be merged first so for now still a draft. |
ehelms
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because it includes #417 and relies on theforeman/puppet-candlepin#139.