Fixes #28934: Install rh-postgresql12 in devel scenario #463

ehelms · 2020-02-05T13:26:17Z

No description provided.

ekohl · 2020-02-05T13:32:45Z

hooks/pre/30-install_redis_scl.rb

@@ -1,4 +1,4 @@
 # Working around https://tickets.puppetlabs.com/browse/PUP-2169
-if el7? && local_redis?
+if (el7? && local_redis?) || devel_scenario?


Suggested change

if (el7? && local_redis?) || devel_scenario?

if el7? && (local_redis? || devel_scenario?)

The other solution is to modify local_redis? to look at devel_scenario? which might actually be cleaner.

Same comment for the other file.

I considered that. That seemed to just put more logic into local than I wanted. I didn't feel there was really any clean scenario here at present.

IMHO the SCL part is el7 specific so at least the suggestion I made still makes sense to me.

johnpmitsch · 2020-02-05T14:09:41Z

@ehelms I tried spinning up a box without running the installer and patching it manually, but still hit some errors. Am I using the right arguments here?

[vagrant@centos7-katello-devel-psql foreman-installer]$ sudo foreman-installer --scenario katello-devel  --katello-devel-scl-ruby=rh-ruby25 --katello-devel-admin-password changeme --disable-system-checks
package puppet-agent-oauth is not installed
Notice: /Package[rh-redis5-redis]/ensure: created
package { 'rh-redis5-redis':
  ensure   => '5.0.5-1.el7',
  provider => 'yum',
}
/opt/puppetlabs/bin/puppet resource package rh-redis5-redis ensure=installed finished successfully!
Notice: /Package[rh-postgresql12-postgresql-server]/ensure: created
package { 'rh-postgresql12-postgresql-server':
  ensure   => '12.1-2.el7',
  provider => 'yum',
}
/opt/puppetlabs/bin/puppet resource package rh-postgresql12-postgresql-server ensure=installed finished successfully!
Preparing installation Info: Class[Katello_devel::Setup]: Scheduling refr
 'scl enable rh-ruby25 rh-nodejs10 'bundle install --without mysql:mysql2 --retry 3 --jobs 3 --path .vendor'' returned 5 instead of one of [0]
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/errors.rb:157:in `fail'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/exec.rb:183:in `sync'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:241:in `sync'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:136:in `sync_if_needed'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:90:in `block in perform_changes'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:89:in `each'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:89:in `perform_changes'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:21:in `evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:267:in `apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:287:in `eval_resource'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:191:in `call'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:191:in `block (2 levels) in evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:521:in `block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:520:in `thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:191:in `block in evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:122:in `traverse'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:178:in `evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:240:in `block (2 levels) in apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:521:in `block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:520:in `thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:239:in `block in apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/log.rb:161:in `with_destination'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/report.rb:146:in `as_logging_destination'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:238:in `apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:188:in `block (2 levels) in apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:521:in `block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:520:in `thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:187:in `block in apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:233:in `block in benchmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:232:in `benchmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:186:in `apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:395:in `run_internal'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:236:in `block in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:62:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:274:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:213:in `run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:343:in `apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:260:in `block (2 levels) in main'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:62:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:274:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:243:in `block in main'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:62:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:274:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:207:in `main'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:177:in `run_command'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:382:in `block in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:710:in `exit_on_fail'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:382:in `run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:143:in `run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:77:in `execute'
/opt/puppetlabs/puppet/bin/puppet:5:in `<main>'
 /Stage[main]/Katello_devel::Setup/Katello_devel::Bundle[install --without mysql:mysql2 --retry 3 --jobs 3 --path .vendor]/Exec[bundle-install --without mysql:mysql2 --retr
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/errors.rb:157:in `fail'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/exec.rb:183:in `sync'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/exec.rb:649:in `refresh'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/event_manager.rb:149:in `process_callback'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/event_manager.rb:34:in `block in process_events'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/event_manager.rb:121:in `block in queued_events'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/event_manager.rb:120:in `each'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/event_manager.rb:120:in `queued_events'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/event_manager.rb:33:in `process_events'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:288:in `eval_resource'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:191:in `call'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:191:in `block (2 levels) in evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:521:in `block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:520:in `thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:191:in `block in evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:122:in `traverse'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction.rb:178:in `evaluate'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:240:in `block (2 levels) in apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:521:in `block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:520:in `thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:239:in `block in apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/log.rb:161:in `with_destination'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/transaction/report.rb:146:in `as_logging_destination'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:238:in `apply'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:188:in `block (2 levels) in apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:521:in `block in thinmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:520:in `thinmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:187:in `block in apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:233:in `block in benchmark'
/opt/puppetlabs/puppet/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:232:in `benchmark'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:186:in `apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:395:in `run_internal'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:236:in `block in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:62:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:274:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/configurer.rb:213:in `run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:343:in `apply_catalog'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:260:in `block (2 levels) in main'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:62:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:274:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:243:in `block in main'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/context.rb:62:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:274:in `override'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:207:in `main'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application/apply.rb:177:in `run_command'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:382:in `block in run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util.rb:710:in `exit_on_fail'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:382:in `run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:143:in `run'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:77:in `execute'
/opt/puppetlabs/puppet/bin/puppet:5:in `<main>'
Preparing installation Done                                              
  Something went wrong! Check the log for ERROR-level output
  The full log is at /var/log/foreman-installer/katello-devel.log
[vagrant@centos7-katello-devel-psql foreman-installer]$

ehelms · 2020-02-05T16:58:55Z

The error seems unrelated

jturel · 2020-02-05T18:40:47Z

The scl command is scl enable rh-ruby25 rh-nodejs10 'bundle install --without mysql:mysql2 --retry 3 --jobs 3 --path .vendor'

Does it also need to use rh-postgresql12?

ehelms · 2020-02-06T15:18:31Z

We shouldn't have to care about what SCL postgresql is running in.

ehelms · 2020-02-07T02:48:24Z

@jturel you were right in the end, the SCL is needed for devel bundle calls due to building the pg gem natively. Therefore I have opened the following to be needed as well:

jturel · 2020-02-07T13:48:25Z

Nice. That explains why I had to remove .vendor (existing vm) and build with the SCL (sorry for not mentioning that)

jturel · 2020-02-08T17:26:45Z

Works for me with the associated PRs - was able to spin up a fresh box

[vagrant@centos7-katello-devel ~]$ curl localhost:3000/katello/api/v2/ping
  {"status":"ok","services":{"pulp":{"status":"ok","duration_ms":"154"},"pulp_auth":{"status":"ok","duration_ms":"48"},"candlepin":{"status":"ok","duration_ms":"45"},"candlepin_auth":{"status":"ok","duration_ms":"22"},"foreman_tasks":{"status":"ok","duration_ms":"1753"},"katello_events":{"status":"ok","message":"0 Processed, 0 Failed","duration_ms":"45"},"candlepin_events":{"status":"ok","message":"0 Processed, 0 Failed","duration_ms":"48"}}}

jturel

ACK

ehelms · 2020-02-11T13:08:07Z

Updated, please re-review

theforeman-bot added Needs testing Not yet reviewed labels Feb 5, 2020

ekohl requested changes Feb 5, 2020

View reviewed changes

theforeman-bot added Waiting on contributor and removed Not yet reviewed labels Feb 5, 2020

jturel approved these changes Feb 8, 2020

View reviewed changes

ianballou mentioned this pull request Feb 10, 2020

Fixes #28886 - App applicability associations to InstalledPackage Katello/katello#8549

Merged

Fixes #28934: Install rh-postgresql12 in devel scenario

9c30b46

ehelms force-pushed the fixes-28934 branch from 55a45ac to 9c30b46 Compare February 11, 2020 13:07

theforeman-bot added Needs re-review and removed Waiting on contributor labels Feb 11, 2020

ekohl approved these changes Feb 11, 2020

View reviewed changes

theforeman-bot removed the Needs re-review label Feb 11, 2020

ehelms merged commit 047b0ba into theforeman:develop Feb 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #28934: Install rh-postgresql12 in devel scenario #463

Fixes #28934: Install rh-postgresql12 in devel scenario #463

ehelms commented Feb 5, 2020

ekohl Feb 5, 2020

ehelms Feb 5, 2020

ekohl Feb 11, 2020

johnpmitsch commented Feb 5, 2020

ehelms commented Feb 5, 2020

jturel commented Feb 5, 2020 •

edited

ehelms commented Feb 6, 2020

ehelms commented Feb 7, 2020

jturel commented Feb 7, 2020

jturel commented Feb 8, 2020

jturel left a comment

ehelms commented Feb 11, 2020

	if (el7? && local_redis?) \|\| devel_scenario?
	if el7? && (local_redis? \|\| devel_scenario?)

Fixes #28934: Install rh-postgresql12 in devel scenario #463

Fixes #28934: Install rh-postgresql12 in devel scenario #463

Conversation

ehelms commented Feb 5, 2020

ekohl Feb 5, 2020

Choose a reason for hiding this comment

ehelms Feb 5, 2020

Choose a reason for hiding this comment

ekohl Feb 11, 2020

Choose a reason for hiding this comment

johnpmitsch commented Feb 5, 2020

ehelms commented Feb 5, 2020

jturel commented Feb 5, 2020 • edited

ehelms commented Feb 6, 2020

ehelms commented Feb 7, 2020

jturel commented Feb 7, 2020

jturel commented Feb 8, 2020

jturel left a comment

Choose a reason for hiding this comment

ehelms commented Feb 11, 2020

jturel commented Feb 5, 2020 •

edited