Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rh-postgresql12 role and to katello_devel #1104

Merged
merged 1 commit into from Feb 8, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Feb 7, 2020

No description provided.

Copy link
Member

@rabajaj0509 rabajaj0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This PR fixed my Postgresql issue! thanks @ehelms

ansible.cfg Outdated
@@ -2,7 +2,6 @@
callback_whitelist = profile_tasks,profile_roles
stdout_callback = yaml
display_skipped_hosts = false
verbosity = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we need to remove this one though.

@@ -0,0 +1,18 @@
- name: 'Install SCL repository'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a --- in the beginning of the playbook?

@rabajaj0509
Copy link
Member

@ehelms in the above PR, we are installing the packages, do we need to also enable their services? so that next time if system reboots or starts then the service would be on.

Let me know your thoughts.

@ehelms
Copy link
Member Author

ehelms commented Feb 7, 2020

The installer should handle the actual PG service. This is just to configure the environment to be int he context of the SCL. This is updated

Copy link
Member

@rabajaj0509 rabajaj0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, I have tested this on my instance :)

Copy link
Contributor

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ehelms ehelms merged commit 7dcd91a into theforeman:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants