Refs #29069 - Install pulpcore-selinux if needed #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To work around PUP-2169, the selinux contexts need to be present before the main Puppet run. Because pulpcore-selinux depends on python3-pulpcore, the foreman-installer-katello package can't depend on it.
evgeni
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
You could argue pulpcore-selinux is not an SCL package, so the filename becomes "wrong", but I don't care too much.
Strictly speaking, we could also drop the pulpcore-selinux → python3-pulpcore dependency, as the policy really doesn't apply to any files inside that package, it only labels content folders, that are not created by installing python3-pulpcore at all.
That all said, the given patch solves the issue at hand, so go forth and merge.
Fair point. Perhaps it should be |
ehelms
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work around PUP-2169, the selinux contexts need to be present before the main Puppet run. Because pulpcore-selinux depends on python3-pulpcore, the foreman-installer-katello package can't depend on it.