Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #29541: Use Facter 4 #501

Closed
wants to merge 1 commit into from
Closed

Refs #29541: Use Facter 4 #501

wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 28, 2020

Facter 3 from gem does not install easily on system as it has a
lot of build dependencies.

@ehelms
Refs #29541: Use Facter 4
a1d9004 
Facter 3 from gem does not install easily on system as it has a
lot of build dependencies.
ekohl
ekohl requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed. Facter 3 is still ok to use and Puppet 5 hard requires Facter < 4 so it would be impossible to install that combination anyway.

@ehelms
Copy link
Member Author

ehelms commented Apr 28, 2020

Then let's just drop from source testing like we did here in PR testing - theforeman/foreman-infra#1351

@ehelms ehelms closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @ekohl @theforeman-bot