Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37212 - Retire foreman_setup plugin #10471

Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 28, 2024

No description provided.

@evgeni
Copy link
Member

evgeni commented Feb 28, 2024

Rewrite in what? "whitespace"? ;-)

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message could use a rewrite, otherwise ACK

@ekohl ekohl force-pushed the deb/develop-37212-retire-foreman_setup branch from b36782f to e3263a0 Compare March 26, 2024 12:09
@ekohl
Copy link
Member Author

ekohl commented Mar 26, 2024

Updated, and theforeman/foreman-installer#926 is the installer side.

@ekohl ekohl changed the title Refs #37212 - Rerwite foreman_setup plugin Refs #37212 - Retire foreman_setup plugin Mar 26, 2024
@ekohl
Copy link
Member Author

ekohl commented Mar 26, 2024

#10625 also makes foreman itself conflict with the plugin. Should we do the same here?

@evgeni
Copy link
Member

evgeni commented Mar 26, 2024

I don't think I like that (but can't really say why)

@evgeni evgeni merged commit 785f316 into theforeman:deb/develop Apr 29, 2024
2 checks passed
@ekohl ekohl deleted the deb/develop-37212-retire-foreman_setup branch April 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants