Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foreman_chef to 0.3.1 #1050

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Conversation

ares
Copy link
Member

@ares ares commented Mar 7, 2016

I copied changes from other template, just bumped foreman-plugin build dep, I'd appreciate if someone explained why this one is needed. I'll test scratches in production env so please wait with merging a bit.

@ares
Copy link
Member Author

ares commented Mar 7, 2016

seems to work for me, please tag into 1.11 as well (note that it also updates foreman_chef to 0.3.1), should I update commit/pr message

@domcleal
Copy link
Contributor

domcleal commented Mar 7, 2016

I copied changes from other template, just bumped foreman-plugin build dep, I'd appreciate if someone explained why this one is needed

The foreman-plugin dependency, or generally those changes? The foreman-plugin dep provides some build macros, all of those %foreman_precompile type ones for plugins to use at build time.

Generally though these steps are needed to provide a precompiled (compressed, optimised) .js/.css files inside the package for use in the production environment. This means that at runtime, users don't have to precompile the entire set of application JS+CSS files so it's quick to install and they don't need asset dependencies installed.

The plugin build includes a manifest file (foreman_chef.json) stored in the plugin's installation directory, which lists all of the precompiled assets and their MD5 sums. This is merged into the main application manifest when Foreman starts up for every registered plugin, so Rails is able to serve up the precompiled plugin assets.

@@ -96,6 +94,11 @@ exit 0
%doc %{gem_instdir}/README.md
%{gem_instdir}/Rakefile

%posttrans
%foreman_db_migrate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing db:seed here (removed from line 79), a %foreman_db_seed macro should be available

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

@domcleal
Copy link
Contributor

domcleal commented Mar 7, 2016

should I update commit/pr message

Can do, it'll improve the changelog if you say it's updated to 0.3.1.

@ares ares changed the title Fixes #14052 - fix spec to precompile assets Update foreman_chef to 0.3.1 Mar 7, 2016
@ares
Copy link
Member Author

ares commented Mar 7, 2016

The foreman-plugin dependency, or generally those changes? The foreman-plugin dep provides some build macros, all of those %foreman_precompile type ones for plugins to use at build time.

I was not clear on this one, thanks!

domcleal added a commit that referenced this pull request Mar 7, 2016
Update foreman_chef to 0.3.1
@domcleal domcleal merged commit 2a85347 into theforeman:rpm/develop Mar 7, 2016
@domcleal
Copy link
Contributor

domcleal commented Mar 7, 2016

Thanks @ares, merged to both develop/1.11 and building.

@ares ares deleted the rpm/chef_3 branch March 8, 2016 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants