Drop and obsolete rubygem-foreman_hooks #10624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
rpm/no-hooks-attached
branch
from
131184b
to
1c9a0cd
Compare
ekohl
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Can you open a Redmine issue? This also reminds me to revisit https://projects.theforeman.org/issues/37212.
adamruzicka
force-pushed
the
rpm/no-hooks-attached
branch
from
1c9a0cd
to
35a2481
Compare
|
I think you missed a 2 in the commit message. I was surprised to see it a link there. |
adamruzicka
force-pushed
the
rpm/no-hooks-attached
branch
2 times, most recently
from
3546db4
to
871ac42
Compare
ekohl
reviewed
Mar 25, 2024
| Release: 1%{?dist} | ||
| License: MIT | ||
| Summary: A package to obsolete retired packages | ||
| URL: https://github.com/theforeman/foreman-packaging | ||
| BuildArch: noarch | ||
|
|
||
| Obsoletes: rubygem-fog-google < 1.19.0-2 | ||
| Obsoletes: rubygem-foreman_hooks <= 0.3.17 |
There was a problem hiding this comment.
In other places we use the exact release + 1, so:
Suggested change
| Obsoletes: rubygem-foreman_hooks <= 0.3.17 | |
| Obsoletes: rubygem-foreman_hooks < 0.3.17-4 |
This is a common practice to the point that I don't even know how <= operates in RPM.
adamruzicka
force-pushed
the
rpm/no-hooks-attached
branch
from
871ac42
to
072cb3a
Compare
ehelms
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.