fixes #3115 - don't add foreman to puppet group, done in installer #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dominic, I thought we had trouble getting the installer to do this - did we fix it and I missed it? |
|
I refer the right honourable gentleman to his own handiwork: theforeman/puppet-foreman@df3b6ff :) |
|
Ah I remember now, we gave up on trying to handle the non-all-in-one case automatically and gave the user an option to override the default groups. thanks :) |
|
Added changelog update and merged as 824ca92. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://projects.theforeman.org/issues/3115
Please cherry pick to 1.3.