packaging for puppet-foreman_scap_client [rpm] #1325

shlomizadok · 2016-09-11T12:38:31Z

For plugin updates, please indicate which repos this should be built into:

Nightly
1.13
1.12
1.11

See Foreman's plugin maintainer documentation for more information.

ares · 2016-09-12T07:28:06Z

This is weird, when I try to download the module directly, I'm getting the following output with no redirection

*   Trying 52.10.130.237...
* Connected to forgeapi.puppetlabs.com (52.10.130.237) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* ALPN/NPN, server did not agree to a protocol
* SSL connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate:
*       subject: CN=*.puppetlabs.com
*       start date: čen 24 00:00:00 2016 GMT
*       expire date: srp 29 23:59:59 2019 GMT
*       common name: *.puppetlabs.com
*       issuer: CN=RapidSSL SHA256 CA,O=GeoTrust Inc.,C=US
> GET /v3/files/theforeman-foreman_scap_client-0.3.11.tar.gz HTTP/1.1
> Host: forgeapi.puppetlabs.com
> User-Agent: curl/7.43.0
> Accept: */*
> 
< HTTP/1.1 200 OK
< Server: nginx
< Date: Mon, 12 Sep 2016 07:25:47 GMT
< Content-Type: application/octet-stream
< Transfer-Encoding: chunked
< Status: 200 OK
< Cache-Control: public
< content-disposition: attachment; filename=theforeman-foreman_scap_client-0.3.11.tar.gz
< ETag: "664dddcc163b39ceffea70bfc2208ce1"
< X-Node: forgenext-app06-prod
< X-Revision: 66c9f4d
< Vary: Origin
< X-Content-Type-Options: nosniff
< X-App-Server: forgeapi/forgeapi-i-75aa79ae_forgenext-app06-prod.ops.puppetlabs.net
< X-Lb-Server: forgenext-lb02-prod.ops.puppetl
< X-UUID: D5AF250A:2129_0AE00633:01BB_57D6587A_44310FE:4768

the tarball has 12K, could we make an exception and maybe put this file into packaging repo?

ares · 2016-09-12T10:28:24Z

what's even more weird, following jenkins steps locally lead to working build in koji, I just had to modify tito.props

ares · 2016-09-12T10:32:27Z

btw Shlomi, you might want to add this to this PR

diff --git a/rel-eng/tito.props b/rel-eng/tito.props
index ba5bf1e..f76f2e5 100644
--- a/rel-eng/tito.props
+++ b/rel-eng/tito.props
@@ -362,6 +362,7 @@ whitelist = rubygem-algebrick
 [foreman-plugins-nightly-nonscl-rhel7]
 disttag = .el7
 whitelist = rubygem-algebrick
+  puppet-foreman_scap_client
   rubygem-apipie-params
   rubygem-chef-api
   rubygem-concurrent-ruby
@@ -397,6 +398,7 @@ whitelist = rubygem-algebrick
 [foreman-plugins-nightly-fedora24]
 disttag = .fc24
 whitelist = rubygem-algebrick
+  puppet-foreman_scap_client
   rubygem-angular-rails-templates
   rubygem-apipie-params
   rubygem-azure

shlomizadok · 2016-09-13T06:43:11Z

@ares - thanks, I have added the changes to tito.props
Got no clue why this is failing :/

ares · 2016-09-13T09:21:41Z

could someone from @theforeman/packaging please take a look? would it be possible to avoid using annex for this package? or does anyone have some idea why it reports redirects?

domcleal · 2016-09-13T14:09:34Z

git-annex 3.x doesn't support HTTPS sources, only HTTP sources, but Puppet Forge is only accessible over HTTPS. We now have enough EL7 slaves that I can switch these tests over to run on EL7 with 5.x which should fix the problem. I'll re-test it when I've updated Jenkins.

domcleal · 2016-09-13T14:09:43Z

puppet-foreman_scap_client/puppet-foreman_scap_client.spec

+Source0:    https://forgeapi.puppetlabs.com/v3/files/%{puppet_full_name}-%{version}.tar.gz
+BuildArch:  noarch
+Requires:   puppet >= 2.7.0
+Requires:   puppetlabs-stdlib >= 4.2.0


What provides this?

domcleal · 2016-09-13T14:46:39Z

[test] - packaging PR test slave updated to EL7, ought to fix git-annex HTTPS handling.

shlomizadok · 2016-09-15T08:45:33Z

@domcleal - I kinda got lost here... am I doing this right?

domcleal

Please check it builds correctly with the provided mock configs, it seems to be failing tests.

Also needs adding to comps/plugins.

domcleal · 2016-09-15T08:47:48Z

puppet-foreman_scap_client/puppet-foreman_scap_client.spec

+Source0:    https://forgeapi.puppetlabs.com/v3/files/%{puppet_full_name}-%{version}.tar.gz
+BuildArch:  noarch
+Requires:   puppet >= 2.7.0
+Requires:   puppetlabs-stdlib >= 4.2.0


What provides this?

seems it got into epel 7

https://dl.fedoraproject.org/pub/epel/7/x86_64/p/puppetlabs-stdlib-4.5.1-2.20150121git7a91f20.el7.noarch.rpm

domcleal · 2016-09-15T08:48:30Z

puppet-foreman_scap_client/puppet-foreman_scap_client.spec

+%{puppet_modules_dir}/%{puppet_module}/checksums.json
+%{puppet_modules_dir}/%{puppet_module}/Gemfile
+%{puppet_modules_dir}/%{puppet_module}/Rakefile
+%{puppet_modules_dir}/%{puppet_module}/lib/facter/rh_certificates.rb


Just list %{puppet_modules_dir}/%{puppet_module}/lib so it includes everything below lib/. Ditto with manifests, templates.

domcleal · 2016-09-15T08:48:55Z

puppet-foreman_scap_client/puppet-foreman_scap_client.spec

+%{puppet_modules_dir}/%{puppet_module}/manifests/params.pp
+%{puppet_modules_dir}/%{puppet_module}/templates/config.yaml.erb
+%{puppet_modules_dir}/%{puppet_module}/templates/cron.erb
+%dir %{puppet_modules_dir}/%{puppet_module}


Move this between the %doc and files within this dir, it should be first.

domcleal · 2016-09-15T08:49:15Z

rel-eng/tito.props

@@ -362,6 +362,7 @@ whitelist = rubygem-algebrick
 [foreman-plugins-nightly-nonscl-rhel7]
 disttag = .el7
 whitelist = rubygem-algebrick
+  puppet-foreman_scap_client


Move this up a line, it's not alphabetical.

domcleal · 2016-09-15T08:49:18Z

rel-eng/tito.props

@@ -397,6 +398,7 @@ whitelist = rubygem-algebrick
 [foreman-plugins-nightly-fedora24]
 disttag = .fc24
 whitelist = rubygem-algebrick
+  puppet-foreman_scap_client


domcleal · 2016-09-15T08:49:50Z

puppet-foreman_scap_client/puppet-foreman_scap_client.spec

+
+%files
+%doc NEWS COPYING README.md
+%{puppet_modules_dir}/%{puppet_module}/metadata.json


Consider defining %{puppet_module_dir} to make this less repetitive.

How do I define this?

Exactly the same way you already have: https://github.com/theforeman/foreman-packaging/pull/1325/files#diff-b80b253e976748958e41ab342c0c2d30R4

domcleal · 2016-09-15T08:51:11Z

puppet-foreman_scap_client/puppet-foreman_scap_client.spec

+
+%install
+mkdir -p %{buildroot}/%{puppet_modules_dir}/%{puppet_module}
+cp -rp %{puppet_modules_dir}/%{puppet_module} %{buildroot}/%{puppet_modules_dir}/%{puppet_module}/


This is failing, check the source exists (probably cp -rp . %{buildroot}/%{puppet_modules_dir}/%{puppet_module} or similar), you need to be copying from the unpacked source, not the installation dir.

shlomizadok · 2016-09-15T09:31:46Z

@domcleal, thanks for the help.
I have removed the "Requires puppetlabs-stdlib >= 4.2.0" as I am assume we do not provide this (and it could be installed via puppet forge)

domcleal · 2016-09-15T09:35:29Z

I don't think removing the dependency is correct, it's specified as a dep within the metadata.json - so to use this package shouldn't require the user to install a package locally (else, why not just do it with this module too?). The package is available in Fedora, but not EPEL7.

shlomizadok · 2016-09-15T10:14:24Z

Got it. Will return it. How do I make the package available in EPEL7?

domcleal · 2016-09-15T10:16:03Z

I suggest filing a bug against the package first, else request the branch (https://fedoraproject.org/wiki/EPEL/FAQ#How_do_I_request_a_EPEL_branch_for_an_existing_Fedora_package.3F).

shlomizadok · 2016-09-15T10:46:56Z

@domcleal - thanks, filed a bug and requested for EPEL7 branch.

ares · 2016-09-16T11:28:55Z

meanwhile we could package stdlib too I guess, it does not have any other deps

shlomizadok · 2016-09-21T11:46:31Z

@domcleal - EPEL7 has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/puppetlabs-stdlib/

domcleal · 2016-09-21T11:51:16Z

Yes, only the branch though - the build hasn't even moved into epel-testing yet: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0c2c4e4800

domcleal · 2016-10-13T08:45:13Z

rel-eng/tito.props

@@ -364,7 +364,8 @@ scl = tfm

 [foreman-nightly-fedora24]
 disttag = .fc24
-whitelist = foreman
+whitelist = puppet-foreman_scap_client


Please remove it from here, it should only be in the plugin sections.

Added by mistake. Removed.

domcleal · 2016-10-13T10:42:33Z

Merged and will build, thanks @shlomizadok.

theforeman-bot added Needs testing Not yet reviewed labels Sep 11, 2016

shlomizadok force-pushed the puppet-foreman_scap_client branch from b22a426 to 96ecfcc Compare September 13, 2016 06:42

domcleal reviewed Sep 13, 2016
View reviewed changes

domcleal added Waiting on contributor and removed Not yet reviewed labels Sep 13, 2016

domcleal changed the title ~~packaging for puppet-foreman_scap_client~~ packaging for puppet-foreman_scap_client [rpm] Sep 14, 2016

shlomizadok force-pushed the puppet-foreman_scap_client branch from 96ecfcc to a8ab89a Compare September 15, 2016 08:44

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Sep 15, 2016

domcleal suggested changes Sep 15, 2016

View reviewed changes

domcleal added Waiting on contributor and removed Needs re-review labels Sep 15, 2016

shlomizadok force-pushed the puppet-foreman_scap_client branch from a8ab89a to 42e3fa2 Compare September 15, 2016 09:16

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Sep 15, 2016

shlomizadok force-pushed the puppet-foreman_scap_client branch from 42e3fa2 to 79f509a Compare September 15, 2016 09:25

domcleal added Waiting on contributor and removed Needs re-review labels Sep 15, 2016

shlomizadok force-pushed the puppet-foreman_scap_client branch from 79f509a to 22f1eca Compare September 15, 2016 10:34

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Sep 15, 2016

domcleal added the Blocked on build label Sep 16, 2016

domcleal removed the Blocked on build label Oct 7, 2016

shlomizadok force-pushed the puppet-foreman_scap_client branch from 22f1eca to c2ed288 Compare October 9, 2016 14:33

domcleal suggested changes Oct 13, 2016

View reviewed changes

domcleal added Waiting on contributor and removed Needs re-review labels Oct 13, 2016

packaging for puppet-foreman_scap_client [rpm]

29c64d0

shlomizadok force-pushed the puppet-foreman_scap_client branch from c2ed288 to 29c64d0 Compare October 13, 2016 10:21

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Oct 13, 2016

domcleal approved these changes Oct 13, 2016

View reviewed changes

domcleal merged commit 68848d4 into theforeman:rpm/develop Oct 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

packaging for puppet-foreman_scap_client [rpm] #1325

packaging for puppet-foreman_scap_client [rpm] #1325

shlomizadok commented Sep 11, 2016

ares commented Sep 12, 2016

ares commented Sep 12, 2016

ares commented Sep 12, 2016

shlomizadok commented Sep 13, 2016

ares commented Sep 13, 2016

domcleal commented Sep 13, 2016

domcleal Sep 13, 2016

domcleal commented Sep 13, 2016

shlomizadok commented Sep 15, 2016

domcleal left a comment

domcleal Sep 15, 2016

ares Oct 7, 2016

domcleal Sep 15, 2016

domcleal Sep 15, 2016

domcleal Sep 15, 2016

domcleal Sep 15, 2016

domcleal Sep 15, 2016

shlomizadok Sep 15, 2016

domcleal Sep 15, 2016

domcleal Sep 15, 2016

shlomizadok commented Sep 15, 2016 •

edited

domcleal commented Sep 15, 2016

shlomizadok commented Sep 15, 2016

domcleal commented Sep 15, 2016

shlomizadok commented Sep 15, 2016

ares commented Sep 16, 2016

shlomizadok commented Sep 21, 2016

domcleal commented Sep 21, 2016

domcleal Oct 13, 2016

shlomizadok Oct 13, 2016

domcleal commented Oct 13, 2016

packaging for puppet-foreman_scap_client [rpm] #1325

packaging for puppet-foreman_scap_client [rpm] #1325

Conversation

shlomizadok commented Sep 11, 2016

ares commented Sep 12, 2016

ares commented Sep 12, 2016

ares commented Sep 12, 2016

shlomizadok commented Sep 13, 2016

ares commented Sep 13, 2016

domcleal commented Sep 13, 2016

Choose a reason for hiding this comment

domcleal commented Sep 13, 2016

shlomizadok commented Sep 15, 2016

domcleal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shlomizadok commented Sep 15, 2016 • edited

domcleal commented Sep 15, 2016

shlomizadok commented Sep 15, 2016

domcleal commented Sep 15, 2016

shlomizadok commented Sep 15, 2016

ares commented Sep 16, 2016

shlomizadok commented Sep 21, 2016

domcleal commented Sep 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domcleal commented Oct 13, 2016

shlomizadok commented Sep 15, 2016 •

edited