Add compression-webpack-plugin #1453

tbrisker · 2016-12-18T13:23:29Z

This depends on theforeman/foreman#3883 being merged.

For plugin updates, please indicate which repos this should be built into:

Nightly
1.14
1.13
1.12

See Foreman's plugin maintainer documentation for more information.

lzap · 2017-01-02T14:45:59Z

FYI core was merged.

domcleal · 2017-01-03T08:50:58Z

This is still failing to build, please fix the failure and ensure comments/FIXME comments are resolved in the spec file.

tbrisker · 2017-01-03T09:26:27Z

@domcleal updated the spec file, hopefully tests will pass now, thanks.

tbrisker · 2017-01-04T13:03:26Z

@domcleal fixed the failing build, seems to work now.

domcleal · 2017-01-04T13:08:42Z

The spec file lists a large number of bundled packages, but the resulting RPM doesn't seem to contain any node_modules directory - only the top-level package contents:

/usr/lib/node_modules/compression-webpack-plugin
/usr/lib/node_modules/compression-webpack-plugin/.gitattributes
/usr/lib/node_modules/compression-webpack-plugin/.npmignore
/usr/lib/node_modules/compression-webpack-plugin/README.md
/usr/lib/node_modules/compression-webpack-plugin/index.js
/usr/lib/node_modules/compression-webpack-plugin/package.json

Please check the dependencies are present.

tbrisker · 2017-01-04T18:45:14Z

looks like this is pulling in a ton of unwanted optional dependencies due to an issue with how npm registry lists dependcies. npm/npm-remote-ls#32 should fix it and significantly reduce the size of this package, I'll try to get this fixed.

ehelms · 2017-01-09T17:06:10Z

@tbrisker is the npm-remote-ls fix required to generate the package or to build the package? If the former, could we build out the spec and dependencies by hand so as to get this built given it will be required to get nightly builds going.

dLobatog · 2017-01-10T13:04:35Z

@tbrisker I think this could be built manually as 3 packages with the single strategy, it'd save us time until they merge the npm-remote-ls fix.

@ehelms It's not strictly required but without it, the bundle package will be huge, when there are only 3 mandatory dependencies in fact.

tbrisker · 2017-01-10T15:46:59Z

Pushed again with only the required deps using the single strategy, @dLobatog @domcleal please re-review.

dLobatog · 2017-01-10T15:55:36Z

@tbrisker This is missing adding the package to foreman.spec

dLobatog · 2017-01-10T15:59:25Z

comps/comps-foreman-fedora24.xml

@@ -29,13 +29,15 @@
      <packagereq type="default">foreman-selinux</packagereq>
      <packagereq type="default">foreman-sqlite</packagereq>
      <packagereq type="default">foreman-vmware</packagereq>
+      <packagereq type="default">nodejs-async</packagereq>


Run ./comps_doc.sh, there are no -doc packages in either of the comps

domcleal · 2017-01-13T09:07:47Z

webpack-sources appears to depend on source-map and source-list-map, but these dependencies aren't either here or bundled. Can you check the package deps resolve?

domcleal

nodejs-webpack-sources has unresolved deps.

tbrisker · 2017-01-15T11:34:28Z

@domcleal Thanks, updated with those 2 packages as well.

domcleal · 2017-01-16T09:41:29Z

nodejs-source-list-map/nodejs-source-list-map.spec

+%if 0%{?enable_tests}
+%check
+%{nodejs_symlink_deps} --check
+#$CHECK


Useless comment.

domcleal · 2017-01-16T09:41:58Z

nodejs-source-map/nodejs-source-map.spec

+Version: 0.5.6
+Release: 1%{?dist}
+Summary: Generates and consumes source maps
+License: BSD-3-Clause


domcleal · 2017-01-16T09:42:07Z

nodejs-source-map/nodejs-source-map.spec

+%if 0%{?enable_tests}
+%check
+%{nodejs_symlink_deps} --check
+#$CHECK


domcleal · 2017-01-16T09:42:11Z

nodejs-source-map/nodejs-source-map.spec

+%files
+%{nodejs_sitelib}/%{npm_name}
+%doc LICENSE
+%doc CHANGELOG.md


-doc subpackage

domcleal · 2017-01-16T09:44:39Z

comps/comps-foreman-fedora24.xml

@@ -29,13 +29,15 @@
      <packagereq type="default">foreman-selinux</packagereq>
      <packagereq type="default">foreman-sqlite</packagereq>
      <packagereq type="default">foreman-vmware</packagereq>
+      <packagereq type="default">nodejs-async</packagereq>


nodejs-async 1.5's already in the distribution, is the older dep going to resolve correctly, since it's 0.2.x? Bundling the dependency would be preferable I think in this case.

tbrisker · 2017-01-22T13:13:21Z

Yet another try, back to bundled.

domcleal · 2017-01-23T08:16:29Z

Please check the RPM builds, there is a failure.

tbrisker · 2017-01-23T12:00:03Z

I give up. The time and effort wasted on making these useless rpms is ridiculous, instead of just running an npm install and adding node_modules to the sources passed to koji prior to build.
Anyone else who want to get this building is welcome to, I'm not going to sink any more hours into figuring out why this fails to build.

theforeman-bot added Needs testing Not yet reviewed labels Dec 18, 2016

tbrisker mentioned this pull request Dec 18, 2016

Fixes #16682 - Compress webpack compiled assets theforeman/foreman#3883

Merged

domcleal added the After core merge label Dec 19, 2016

domcleal added Waiting on contributor and removed After core merge labels Jan 3, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch from 4d8571f to 6661622 Compare January 3, 2017 09:25

theforeman-bot added Needs testing and removed Waiting on contributor labels Jan 3, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch 2 times, most recently from 9934c7c to 1c3b47f Compare January 4, 2017 11:28

domcleal added Waiting on contributor and removed Not yet reviewed labels Jan 4, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch from 1c3b47f to 7012faa Compare January 10, 2017 15:46

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jan 10, 2017

dLobatog suggested changes Jan 10, 2017

View reviewed changes

theforeman-bot added Waiting on contributor and removed Needs re-review labels Jan 10, 2017

domcleal added Waiting on contributor and removed Needs re-review labels Jan 13, 2017

domcleal suggested changes Jan 13, 2017

View reviewed changes

theforeman-bot added the Waiting on contributor label Jan 13, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch from c894e5f to 06b6fb7 Compare January 15, 2017 11:33

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jan 15, 2017

domcleal suggested changes Jan 16, 2017

View reviewed changes

theforeman-bot added Waiting on contributor and removed Needs re-review labels Jan 16, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch from 06b6fb7 to d44199b Compare January 22, 2017 13:12

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jan 22, 2017

domcleal added Waiting on contributor and removed Needs re-review labels Jan 23, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch from d44199b to e2be899 Compare January 23, 2017 08:45

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jan 23, 2017

tbrisker force-pushed the rpm/compression-webpack-plugin branch from e2be899 to 6d6010a Compare January 23, 2017 08:57

Add compression-webpack-plugin

ba33463

tbrisker force-pushed the rpm/compression-webpack-plugin branch from 6d6010a to ba33463 Compare January 23, 2017 11:47

domcleal closed this Jan 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add compression-webpack-plugin #1453

Add compression-webpack-plugin #1453

tbrisker commented Dec 18, 2016

lzap commented Jan 2, 2017

domcleal commented Jan 3, 2017

tbrisker commented Jan 3, 2017

tbrisker commented Jan 4, 2017

domcleal commented Jan 4, 2017

tbrisker commented Jan 4, 2017

ehelms commented Jan 9, 2017

dLobatog commented Jan 10, 2017

tbrisker commented Jan 10, 2017

dLobatog commented Jan 10, 2017

dLobatog Jan 10, 2017

domcleal commented Jan 13, 2017

domcleal left a comment

tbrisker commented Jan 15, 2017

domcleal Jan 16, 2017

domcleal Jan 16, 2017

domcleal Jan 16, 2017

domcleal Jan 16, 2017

domcleal Jan 16, 2017

tbrisker commented Jan 22, 2017

domcleal commented Jan 23, 2017

tbrisker commented Jan 23, 2017

Add compression-webpack-plugin #1453

Add compression-webpack-plugin #1453

Conversation

tbrisker commented Dec 18, 2016

lzap commented Jan 2, 2017

domcleal commented Jan 3, 2017

tbrisker commented Jan 3, 2017

tbrisker commented Jan 4, 2017

domcleal commented Jan 4, 2017

tbrisker commented Jan 4, 2017

ehelms commented Jan 9, 2017

dLobatog commented Jan 10, 2017

tbrisker commented Jan 10, 2017

dLobatog commented Jan 10, 2017

dLobatog Jan 10, 2017

Choose a reason for hiding this comment

domcleal commented Jan 13, 2017

domcleal left a comment

Choose a reason for hiding this comment

tbrisker commented Jan 15, 2017

domcleal Jan 16, 2017

Choose a reason for hiding this comment

domcleal Jan 16, 2017

Choose a reason for hiding this comment

domcleal Jan 16, 2017

Choose a reason for hiding this comment

domcleal Jan 16, 2017

Choose a reason for hiding this comment

domcleal Jan 16, 2017

Choose a reason for hiding this comment

tbrisker commented Jan 22, 2017

domcleal commented Jan 23, 2017

tbrisker commented Jan 23, 2017