Provide Copr releaser and fix building of nodejs-brace #1709

xsuchy · 2017-06-29T10:39:55Z

For plugin updates, please indicate which repos this should be built into:

Nightly
1.15
1.14
1.13

- Fix few smaller issues (mhulan@redhat.com)

- Merge pull request theforeman#62 from ares/master (ares@igloonet.cz) - Fix dumping 'false' default values (mhulan@redhat.com)

- Display fatal errors on STDOUT (mhulan@redhat.com)

- Update to v0.0.2 (dcleal@redhat.com)

- Display fatal errors on STDOUT (mhulan@redhat.com)

- Update to v0.0.2 (dcleal@redhat.com)

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.16 (mbacovsk@redhat.com)

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.17 (mbacovsk@redhat.com)

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.16 (mbacovsk@redhat.com)

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.17 (mbacovsk@redhat.com)

- Bump to 0.1.11 (mbacovsk@redhat.com)

- Bump to 0.1.11 (mbacovsk@redhat.com) - Bump to 0.1.10 (mbacovsk@redhat.com)

- Fix --no-colors issues with older highline (mhulan@redhat.com)

- rebase to 2.6.2 release (dcleal@redhat.com) - rebase to 2.6.0 release (msuchy@redhat.com)

- Update to v0.1.4 (dcleal@redhat.com)

Adding foreman_reserve plugin to comps

- Rebase to rbovirt 0.0.22 (dcleal@redhat.com)

- rebase to 2.6.3 release (dcleal@redhat.com)

- Rebase to rbovirt 0.0.22 (dcleal@redhat.com)

- Rebase to rbovirt 0.0.23 (dcleal@redhat.com)

Dump PR, I know, but since rpm/develop was monospaced and deb/develop was just in between quotes I figured it was a mistake..

README typo

ehelms · 2017-07-01T03:40:45Z

rel-eng/packages/nodejs-brace

@@ -1 +1 @@
-0.10.0-1.fm1_15 nodejs-brace/
+0.10.0-2.fm1_16 nodejs-brace/


This is unneeded, tito will generate this when we tag.

I done it with tito tag this PR include even the tag.

How do I see that the PR includes a tag? I didn't even think it was possible to push a tag to a PR? I appreciate trying to get ahead, but I honestly think its easier to just revert the tito tag and let us do that when we do a release post merge.

ehelms · 2017-07-01T03:40:50Z

nodejs-brace/nodejs-brace.spec

@@ -53,6 +52,9 @@ cp -pf LICENSE README.md ../../
 %doc README.md

 %changelog
+* Thu Jun 29 2017 Miroslav Suchý <msuchy@redhat.com> 0.10.0-2
+- correctly provides bundled() (msuchy@redhat.com)


This is unneeded, tito will generate this when we tag.

ehelms · 2017-07-01T03:41:52Z

nodejs-brace/nodejs-brace.spec

@@ -22,8 +22,7 @@ ExclusiveArch: %{nodejs_arches} noarch
 ExclusiveArch: %{ix86} x86_64 %{arm} noarch
 %endif
 Provides: npm(%{npm_name}) = %{version}
-Provides: bundled-npm(brace) = 0.10.0


Intentional to remove brace dependency?

ahh npm(brace) != nodejs(brace) good catch

ehelms · 2017-07-01T03:42:17Z

[test]

xsuchy · 2017-07-11T11:45:55Z

removed the tag and updated

mmoll · 2017-07-11T12:16:27Z

[test]

lzap · 2017-07-12T11:33:47Z

So I assume this will work with all the packages except the special ones we have extra releases written for (foreman, foreman-installer, smart-proxy...), will it?

The webpack build error is unrelated. +1

ehelms · 2017-07-12T13:10:00Z

foreman/README

@@ -0,0 +1,2 @@
+this package can be built using:
+tito release copr-nightly --arg jenkins_job=test_develop


I think this would live better in a similar section to https://github.com/theforeman/foreman-packaging/blob/rpm/develop/README.md#with-koji-access as its likely to just get lost here and be thought of as a source file.

mmoll · 2017-08-19T22:04:21Z

@xsuchy please rebase

dLobatog

I agree with @ehelms on the need to move the README file to the general README. @xsuchy Are you still interested on maintaining this Copr? Who else has access to it?

xsuchy · 2017-09-26T20:27:57Z

?? I rebased and this get closed?
I will create new one.

Dominic Cleal and others added 30 commits January 27, 2014 09:52

refs theforeman#3539 - remove unused -mysql packages

2f0fdb7

Update rubygem-kafo to 0.3.9-1.el6

6e00218

- Fix few smaller issues (mhulan@redhat.com)

Update rubygem-kafo to 0.3.9-1.fc19

220020f

- Fix few smaller issues (mhulan@redhat.com)

Update rubygem-kafo to 0.3.10-1.el6

09c7a0a

- Merge pull request theforeman#62 from ares/master (ares@igloonet.cz) - Fix dumping 'false' default values (mhulan@redhat.com)

Update rubygem-kafo to 0.3.10-1.fc19

724b739

- Merge pull request theforeman#62 from ares/master (ares@igloonet.cz) - Fix dumping 'false' default values (mhulan@redhat.com)

Update rubygem-kafo to 0.3.11-1.el6

b5fdbaf

- Display fatal errors on STDOUT (mhulan@redhat.com)

Update ruby193-rubygem-foreman_custom_parameters to 0.0.2-1.el6

067b7f9

- Update to v0.0.2 (dcleal@redhat.com)

Update rubygem-kafo to 0.3.11-1.fc19

f1c881b

- Display fatal errors on STDOUT (mhulan@redhat.com)

Update rubygem-foreman_custom_parameters to 0.0.2-1.fc19

6bd0e78

- Update to v0.0.2 (dcleal@redhat.com)

Update rubygem-hammer_cli to 0.0.18-1.el6

90bce75

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.16 (mbacovsk@redhat.com)

Update rubygem-hammer_cli_foreman to 0.0.18-1.el6

fb9be06

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.17 (mbacovsk@redhat.com)

Update rubygem-hammer_cli to 0.0.18-1.fc19

eeec779

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.16 (mbacovsk@redhat.com)

Update rubygem-hammer_cli_foreman to 0.0.18-1.fc19

5b38f92

- Bump to 0.0.18 (mbacovsk@redhat.com) - Bump to 0.0.17 (mbacovsk@redhat.com)

Update ruby193-rubygem-foreman_api to 0.1.11-1.el6

c3b93e4

- Bump to 0.1.11 (mbacovsk@redhat.com)

Update rubygem-foreman_api to 0.1.11-1.el6

96a3f5b

- Bump to 0.1.11 (mbacovsk@redhat.com) - Bump to 0.1.10 (mbacovsk@redhat.com)

Update rubygem-foreman_api to 0.1.11-1.fc19

2930a2c

- Bump to 0.1.11 (mbacovsk@redhat.com) - Bump to 0.1.10 (mbacovsk@redhat.com)

Update rubygem-kafo to 0.3.12-1.el6

c96179c

- Fix --no-colors issues with older highline (mhulan@redhat.com)

Update rubygem-kafo to 0.3.12-1.fc19

cdc5c4d

- Fix --no-colors issues with older highline (mhulan@redhat.com)

Update ruby193-rubygem-scoped_search to 2.6.2-1.el6

5f6be00

- rebase to 2.6.2 release (dcleal@redhat.com) - rebase to 2.6.0 release (msuchy@redhat.com)

Update ruby193-rubygem-spice-html5-rails to 0.1.4-1.el6

81f723e

- Update to v0.1.4 (dcleal@redhat.com)

Update rubygem-spice-html5-rails to 0.1.4-1.fc19

4e9c1f1

- Update to v0.1.4 (dcleal@redhat.com)

Adding foreman_reserve plugin to comps

6eea080

Merge pull request theforeman#182 from lzap/comps-reserve

e1687df

Adding foreman_reserve plugin to comps

Update ruby193-rubygem-rbovirt to 0.0.22-1.el6

8068904

- Rebase to rbovirt 0.0.22 (dcleal@redhat.com)

Update ruby193-rubygem-scoped_search to 2.6.3-1.el6

26e5528

- rebase to 2.6.3 release (dcleal@redhat.com)

New package ruby193-rubygem-foreman_reserve, version 0.1.8.2-2.el6

24c0e6e

Update rubygem-rbovirt to 0.0.22-1.fc19

fcfed97

- Rebase to rbovirt 0.0.22 (dcleal@redhat.com)

New package rubygem-foreman_reserve, version 0.1.8.2-2.fc19

9b401ff

Update ruby193-rubygem-rbovirt to 0.0.23-1.el6

f972f6a

- Rebase to rbovirt 0.0.23 (dcleal@redhat.com)

Update rubygem-rbovirt to 0.0.23-1.fc19

ff1ac8b

- Rebase to rbovirt 0.0.23 (dcleal@redhat.com)

dLobatog and others added 6 commits February 24, 2015 10:17

README typo

a2d9a42

Dump PR, I know, but since rpm/develop was monospaced and deb/develop was just in between quotes I figured it was a mistake..

Merge pull request theforeman#554 from eLobato/patch-1

74d8e93

README typo

Add GitHub PR template to indicate branches for plugin updates

9af75c1

Add 1.13 to repo list

c242893

Add 1.14 to repo list

a56e609

Update PULL_REQUEST_TEMPLATE for 1.15 (theforeman#1567)

f7a46c7

theforeman-bot added Needs testing Not yet reviewed labels Jun 29, 2017

ehelms reviewed Jul 1, 2017

View reviewed changes

xsuchy force-pushed the pr1 branch from d3517d0 to 6048a22 Compare July 3, 2017 07:38

xsuchy force-pushed the pr1 branch from 6048a22 to ed81caf Compare July 11, 2017 11:44

xsuchy force-pushed the pr1 branch from ed81caf to 3242adc Compare July 11, 2017 12:12

ehelms reviewed Jul 12, 2017

View reviewed changes

dLobatog suggested changes Sep 26, 2017

View reviewed changes

theforeman-bot added Waiting on contributor and removed Not yet reviewed labels Sep 26, 2017

xsuchy closed this Sep 26, 2017

xsuchy force-pushed the pr1 branch from 3242adc to f7a46c7 Compare September 26, 2017 20:22

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Sep 26, 2017

xsuchy mentioned this pull request Sep 26, 2017

Provide Copr releaser and fix building of nodejs-brace #1827

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide Copr releaser and fix building of nodejs-brace #1709

Provide Copr releaser and fix building of nodejs-brace #1709

xsuchy commented Jun 29, 2017

ehelms Jul 1, 2017

xsuchy Jul 3, 2017

ehelms Jul 5, 2017

ehelms Jul 1, 2017

ehelms Jul 1, 2017

xsuchy Jul 3, 2017

ehelms commented Jul 1, 2017

xsuchy commented Jul 11, 2017

mmoll commented Jul 11, 2017

lzap commented Jul 12, 2017

ehelms Jul 12, 2017

mmoll commented Aug 19, 2017

dLobatog left a comment

xsuchy commented Sep 26, 2017

		@@ -1 +1 @@
		0.10.0-1.fm1_15 nodejs-brace/
		0.10.0-2.fm1_16 nodejs-brace/

		@@ -0,0 +1,2 @@
		this package can be built using:
		tito release copr-nightly --arg jenkins_job=test_develop

Provide Copr releaser and fix building of nodejs-brace #1709

Provide Copr releaser and fix building of nodejs-brace #1709

Conversation

xsuchy commented Jun 29, 2017

ehelms Jul 1, 2017

Choose a reason for hiding this comment

xsuchy Jul 3, 2017

Choose a reason for hiding this comment

ehelms Jul 5, 2017

Choose a reason for hiding this comment

ehelms Jul 1, 2017

Choose a reason for hiding this comment

ehelms Jul 1, 2017

Choose a reason for hiding this comment

xsuchy Jul 3, 2017

Choose a reason for hiding this comment

ehelms commented Jul 1, 2017

xsuchy commented Jul 11, 2017

mmoll commented Jul 11, 2017

lzap commented Jul 12, 2017

ehelms Jul 12, 2017

Choose a reason for hiding this comment

mmoll commented Aug 19, 2017

dLobatog left a comment

Choose a reason for hiding this comment

xsuchy commented Sep 26, 2017