Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpm/foreman tasks 0.10.3 [rpm] #1821

Closed

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Sep 21, 2017

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.16
  • 1.15
  • 1.14

See Foreman's plugin maintainer documentation for more information.


Requires #1820

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iNecas Can you rebase this one so we can see it builds with the new dynflow? Thanks!

@iNecas
Copy link
Member Author

iNecas commented Sep 27, 2017

rebased

@iNecas
Copy link
Member Author

iNecas commented Oct 2, 2017

@dLobatog It seems dynflow 0.8.30 is in foreman 1.15, but not in 1.16 or nightly http://koji.katello.org/koji/buildinfo?buildID=17046, some missing tags maybe?

@ehelms
Copy link
Member

ehelms commented Oct 2, 2017

Built for nightly -- http://koji.katello.org/koji/taskinfo?taskID=34149

@ehelms
Copy link
Member

ehelms commented Oct 2, 2017

[test]

@ekohl
Copy link
Member

ekohl commented Oct 2, 2017

The tags list appears to be somewhat inconsistent.

$ kkoji list-tags --package tfm-rubygem-dynflow
foreman-1.16-rhel7
foreman-nightly-rhel7
foreman-plugins-1.15-rhel7
foreman-plugins-nightly-rhel7

@iNecas
Copy link
Member Author

iNecas commented Oct 3, 2017

That's probably due to fact that dynflow was made as foreman dependency lately., therefore the transition from plugins

@iNecas
Copy link
Member Author

iNecas commented Oct 3, 2017

[test]

@iNecas
Copy link
Member Author

iNecas commented Oct 3, 2017

It seems the new version of dynflow is still not available in the build root

@ehelms
Copy link
Member

ehelms commented Oct 4, 2017

[test]

@ehelms
Copy link
Member

ehelms commented Oct 4, 2017

@iNecas dependencies fixed -- you should see this fail in the build.log with no file bin/foreman-tasks

@iNecas
Copy link
Member Author

iNecas commented Oct 4, 2017

Ah, we need to finalize https://github.com/theforeman/foreman-packaging/pull/1549/files first.

@mmoll
Copy link

mmoll commented Oct 4, 2017

hrm, why does this work on Debian as it currently is then? Does this mean, the whole tasks executor integration needs to get finished in the 1.16.0 timeframe?

@iNecas
Copy link
Member Author

iNecas commented Oct 4, 2017

If feasible yes, otherwise, I would need to revert the changes in the tasks that removed the service script. I need to check this, but I suspect that the package built, but would not work properly, as the bin script is missing from the sources.

@iNecas
Copy link
Member Author

iNecas commented Dec 16, 2017

@iNecas iNecas closed this Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants