New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rpm/foreman tasks 0.10.3 [rpm] #1821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iNecas Can you rebase this one so we can see it builds with the new dynflow? Thanks!
rebased |
d09fda6
to
073229b
Compare
@dLobatog It seems dynflow 0.8.30 is in foreman 1.15, but not in 1.16 or nightly http://koji.katello.org/koji/buildinfo?buildID=17046, some missing tags maybe? |
Built for nightly -- http://koji.katello.org/koji/taskinfo?taskID=34149 |
[test] |
The tags list appears to be somewhat inconsistent.
|
That's probably due to fact that dynflow was made as foreman dependency lately., therefore the transition from plugins |
[test] |
It seems the new version of dynflow is still not available in the build root |
[test] |
@iNecas dependencies fixed -- you should see this fail in the build.log with no file bin/foreman-tasks |
Ah, we need to finalize https://github.com/theforeman/foreman-packaging/pull/1549/files first. |
hrm, why does this work on Debian as it currently is then? Does this mean, the whole tasks executor integration needs to get finished in the 1.16.0 timeframe? |
If feasible yes, otherwise, I would need to revert the changes in the tasks that removed the service script. I need to check this, but I suspect that the package built, but would not work properly, as the bin script is missing from the sources. |
Closing in favor of https://github.com/theforeman/foreman-packaging/pull/1985/files |
For plugin updates, please indicate which repos this should be built into:
See Foreman's plugin maintainer documentation for more information.
Requires #1820