Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21662 - add foreman-proxy temp path #1942

Merged
merged 1 commit into from Nov 15, 2017
Merged

Fixes #21662 - add foreman-proxy temp path #1942

merged 1 commit into from Nov 15, 2017

Conversation

chris1984
Copy link
Member

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.16
  • 1.15
  • 1.14

See Foreman's plugin maintainer documentation for more information.


@ekohl
Copy link
Member

ekohl commented Nov 14, 2017

I'm not sure the #Bug in the commit message breaks anything but it's not needed. It might also be useful to specify that it's the proxy's temporary path on katello removal because this commit message doesn't tell me much. Other than that I think this is ok.

@chris1984 chris1984 changed the title Fixes #Bug #21662 - add removal path Fixes #21662 - add removal path Nov 14, 2017
@chris1984 chris1984 changed the title Fixes #21662 - add removal path Fixes #21662 - add foreman-proxy temp path Nov 14, 2017
@chris1984
Copy link
Member Author

@ekohl updated the commit and pr message, to reflect that.

@cfouant
Copy link

cfouant commented Nov 15, 2017

ACK - good work, thanks @chris1984

@chris1984
Copy link
Member Author

@mmoll can I get a merge please?

@mmoll
Copy link

mmoll commented Nov 15, 2017

I have no idea of katello, sorry.

@chris1984
Copy link
Member Author

No worries, @ehelms can I get a merge please?

@ehelms ehelms merged commit 23849c2 into theforeman:rpm/develop Nov 15, 2017
@chris1984 chris1984 deleted the path-fix branch November 15, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants