Update fog to 1.42 #1975
Merged
Update fog to 1.42 #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related rubygem-fog-ovirt PR at #1970 |
ekohl
reviewed
Dec 8, 2017
| @@ -49,8 +49,7 @@ Requires: %{?scl_prefix}rubygem(fog-xml) >= 0.1.1 | |||
| Requires: %{?scl_prefix}rubygem(fog-xml) < 0.2.0 | |||
| Requires: %{?scl_prefix}rubygem(ipaddress) >= 0.5 | |||
| Requires: %{?scl_prefix}rubygem(ipaddress) < 1.0 | |||
| Requires: %{?scl_prefix_ruby}rubygem(json) >= 1.8 | |||
| Requires: %{?scl_prefix_ruby}rubygem(json) < 2.0 | |||
| Requires: %{?scl_prefix_ruby}rubygem(json) >= 2.0 | |||
There was a problem hiding this comment.
This requires us to bump to the newer ruby SCL. Will require some coordination with @ehelms.
dLobatog
suggested changes
Dec 18, 2017
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Rebased onto latest rpm/develop, lets see if it turns green. |
|
This is pending a mass rebuild of our existing gems in the new SCL. |
|
[test] |
|
Locally, I had to make this additional change: |
4 tasks
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
I added fog-ovirt into requirements |
|
Looks like rbovirt needs to be rebuilt into the new SCL first. I'll get on that. |
|
Looks like that's part of #2037 |
|
[test] |
1 similar comment
|
[test] |
ehelms
approved these changes
Jan 5, 2018
ekohl
approved these changes
Jan 5, 2018
|
Given @dLobatog wanted to wait for the new SCL (which is here now) I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For plugin updates, please indicate which repos this should be built into:
See Foreman's plugin maintainer documentation for more information.