Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fixes #22343 - Add rubocop for katello-* scripts #2115

Closed
wants to merge 1 commit into from
Closed

[WIP] Fixes #22343 - Add rubocop for katello-* scripts #2115

wants to merge 1 commit into from

Conversation

johnpmitsch
Copy link

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.17
  • 1.16
  • 1.15

See Foreman's plugin maintainer documentation for more information.

@ehelms
Copy link
Member

ehelms commented Jan 19, 2018

I think this means we've entered the realm of needing to get these scripts out of here.

ekohl
ekohl requested changes Jan 22, 2018
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that when you need CI on these scripts, they should live in another repository. foreman_maintain perhaps?

@ekohl ekohl mentioned this pull request Jan 22, 2018
Merged
4 tasks
@johnpmitsch
Copy link
Author

+1 to tackling this when we move the scripts to foreman-maintain (which we are discussing offline). Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
4 participants
@johnpmitsch @ehelms @ekohl @theforeman-bot