fixes #22447 - allows user to bypass logical volume validation #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akofink
approved these changes
Feb 6, 2018
ehelms
reviewed
Feb 6, 2018
katello/katello/backup.rb
Outdated
| @@ -159,6 +159,7 @@ def snapshot_backup | |||
| @snapsize = @options[:snapshot_size] || "2G" | |||
| FileUtils.mkdir_p @mountdir | |||
| confirm unless @options[:confirm] | |||
| validate_logical_volume unless @options[:confirm] | |||
There was a problem hiding this comment.
There is a commit that is needed prior to this that actually adds this function to the file. This one -- http://projects.theforeman.org/issues/22418
(cherry picked from commit c296012)
zjhuntin
force-pushed
the
3.6-cherry-picks
branch
from
e23a07e
to
7fc98c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c296012)
For plugin updates, please indicate which repos this should be built into:
See Foreman's plugin maintainer documentation for more information.