Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22548 - always use the absolute path for @dir #2193

Merged
merged 1 commit into from Feb 16, 2018
Merged

Fixes #22548 - always use the absolute path for @dir #2193

merged 1 commit into from Feb 16, 2018

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Feb 12, 2018

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Feb 12, 2018

@cfouant @johnpmitsch I can haz review?

johnpmitsch
johnpmitsch approved these changes Feb 14, 2018
View reviewed changes
Copy link

@johnpmitsch johnpmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

[root@35-test-box backup]# ~/foreman-packaging/packages/katello/katello/katello-backup .
Starting backup: 2018-02-14 18:53:29 +0000
Creating backup folder /backup/katello-backup-20180214185329

@ekohl ekohl merged commit 3879d30 into theforeman:rpm/develop Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpmitsch johnpmitsch johnpmitsch approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
4 participants
@evgeni @johnpmitsch @ekohl @theforeman-bot