Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update smart-proxy-ansible to 2.0.2 #2241

Merged
merged 1 commit into from Mar 5, 2018
Merged

Update smart-proxy-ansible to 2.0.2 #2241

merged 1 commit into from Mar 5, 2018

Conversation

dLobatog
Copy link
Member

@dLobatog dLobatog commented Mar 1, 2018 •
edited

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.17
  • 1.16
  • 1.15

Changes in 2.0.2 make it work with both 1.17 and 1.16.

This fixes a serious PITA to users: https://community.theforeman.org/t/unable-to-import-ansible-roles/8408

@dLobatog
Copy link
Member Author

dLobatog commented Mar 1, 2018

[test]
[test packaging]
[test rpm] (I didn't push the gem before submitting this PR)

dLobatog
dLobatog commented Mar 5, 2018
View reviewed changes
Copy link
Member Author

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl @ehelms Anything blocking this one? It fixes a bug that annoys quite a few people as you can see on the thread :)

ekohl
ekohl approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had looked at it, but did that on a system without my packaging permissions.

@ekohl ekohl merged commit 27544c1 into theforeman:rpm/develop Mar 5, 2018
@ekohl
Copy link
Member

ekohl commented Mar 5, 2018

Of course I forget that the tagging is no longer needed and now we do need a changelog entry.

@ekohl
Copy link
Member

ekohl commented Mar 5, 2018

nightly: http://koji.katello.org/koji/taskinfo?taskID=85540
1.17: http://koji.katello.org/koji/taskinfo?taskID=85547
1.16: #2249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs testing RPM
Projects
None yet
Milestone
No milestone
3 participants
@dLobatog @ekohl @theforeman-bot