Add rubygem-smart_proxy_dhcp_bluecat package #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Oct 17, 2019
package_manifest.yaml
Outdated
| @@ -414,6 +414,7 @@ foreman_nonscl_packages: | |||
| rubygem-kafo: {} | |||
| rubygem-kafo_parsers: {} | |||
| rubygem-kafo_wizards: {} | |||
| rubygem-smart_proxy_dhcp_bluecat: {} | |||
There was a problem hiding this comment.
I think we need to update our add script to the updated structure. Could you move it to the foreman_proxy_plugin_packages group?
There was a problem hiding this comment.
Maybe the scripts are ok. I think if you only specify the gem name and the template, they end up in the right category. But The usage message does not suggest that.
mdellweg
force-pushed
the
add_dhcp_bluecat
branch
from
bef7067
to
494c873
Compare
mdellweg
force-pushed
the
add_dhcp_bluecat
branch
from
494c873
to
e8c3658
Compare
ehelms
reviewed
Oct 18, 2019
mdellweg
force-pushed
the
add_dhcp_bluecat
branch
from
e8c3658
to
f7a4775
Compare
ehelms
approved these changes
Oct 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.