-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rubygem-smart_proxy_dhcp_bluecat package #4197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the scripts to add packages need some updates. It'd be awesome if you could submit a PR for that as well and regenerate this PR to test it but I'll also accept just fixing it manually in this PR.
package_manifest.yaml
Outdated
@@ -414,6 +414,7 @@ foreman_nonscl_packages: | |||
rubygem-kafo: {} | |||
rubygem-kafo_parsers: {} | |||
rubygem-kafo_wizards: {} | |||
rubygem-smart_proxy_dhcp_bluecat: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update our add script to the updated structure. Could you move it to the foreman_proxy_plugin_packages
group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the scripts are ok. I think if you only specify the gem name and the template, they end up in the right category. But The usage message does not suggest that.
bef7067
to
494c873
Compare
494c873
to
e8c3658
Compare
e8c3658
to
f7a4775
Compare
No description provided.