Bump nodejs-theforeman-vendor to 3.3.2 #4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following PRs need to be merged "together": #4417 #4416 #4413 However, they are blocked on the discussion in theforeman/foreman#7178 |
This was referenced Nov 28, 2019
evgeni
changed the title
ekohl
approved these changes
Dec 2, 2019
evgeni
commented
Dec 2, 2019
| %if 0%{?scl:1} | ||
| BuildRequires: %{?scl_prefix_nodejs}npm | ||
| %else | ||
| %if 0%{?!scl:1} |
There was a problem hiding this comment.
Meh, something is wrong with my nom2rpm..
There was a problem hiding this comment.
I kind of assumed that was intended since non-bundled packages don't really call NPM. Or is it needed for macros?
There was a problem hiding this comment.
Well, I don't know. It wasn't intended, so I was going with whatever was there before
There was a problem hiding this comment.
I still backed out that change, will revisit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.