Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release version to the repo ids #5316

Closed
wants to merge 1 commit into from
Closed

Add release version to the repo ids #5316

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 28, 2020

this removes the need to call yum clean on upgrades as the repo id is
used as the cache key buy yum, and if that changes it will download the
metadata again

@evgeni
Add release version to the repo ids
269521b 
this removes the need to call `yum clean` on upgrades as the repo id is
used as the cache key buy yum, and if that changes it will download the
metadata again
ekohl
ekohl reviewed May 28, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downside is that our Puppet modules can modify these. If they don't reflect the same thing, it may add additional repos. Perhaps the cleanest solution there is to ensure foreman-release is absent?

@evgeni
Copy link
Member Author

evgeni commented May 28, 2020

The downside is that our Puppet modules can modify these. If they don't reflect the same thing, it may add additional repos. Perhaps the cleanest solution there is to ensure foreman-release is absent?

"there" = "in puppet"?

@ekohl
Copy link
Member

ekohl commented May 28, 2020

Yes. https://github.com/theforeman/puppet-foreman/blob/2dc5e7d802e2a11e35bd1e34d28cce05195040ce/manifests/repo.pp#L22-L32 to be precise.

@pcreech
Copy link
Member

pcreech commented Jun 30, 2020

[test rpm]

@evgeni evgeni closed this Jun 30, 2020
@evgeni
Copy link
Member Author

evgeni commented Jun 30, 2020

I'll reopen when I have time to address the puppet part too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
Needs testing Not yet reviewed RPM
Projects
None yet
Milestone
No milestone
4 participants
@evgeni @ekohl @pcreech @theforeman-bot